Skip to content

Commit 9c5e70a

Browse files
committed
chore(vue-eslint-parser): Update to 5.0.0, fix test cases
1 parent 9bf6098 commit 9c5e70a

File tree

5 files changed

+48
-35
lines changed

5 files changed

+48
-35
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"eslint": "^5.0.0"
4747
},
4848
"dependencies": {
49-
"vue-eslint-parser": "^4.0.2"
49+
"vue-eslint-parser": "^5.0.0"
5050
},
5151
"devDependencies": {
5252
"@types/node": "^4.2.16",

tests/lib/rules/no-unused-vars.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ tester.run('no-unused-vars', rule, {
3636
code: '<template><ol v-for="i in data"><li v-for="f in i">{{ f.bar.baz }}</li></ol></template>'
3737
},
3838
{
39-
code: '<template scope="props">{{props}}</template>'
39+
code: '<template><template scope="props">{{props}}</template></template>'
4040
},
4141
{
42-
code: '<template scope="props"><span v-if="props"></span></template>'
42+
code: '<template><template scope="props"><span v-if="props"></span></template></template>'
4343
},
4444
{
4545
code: '<template><div v-for="(item, key) in items" :key="key">{{item.name}}</div></template>'
@@ -57,11 +57,15 @@ tester.run('no-unused-vars', rule, {
5757
errors: ["'i' is defined but never used."]
5858
},
5959
{
60-
code: '<template scope="props"></template>',
60+
code: '<template><span slot-scope="props"></span></template>',
6161
errors: ["'props' is defined but never used."]
6262
},
6363
{
64-
code: '<template v-for="i in 5"><comp v-for="j in 10">{{i}}{{i}}</comp></template>',
64+
code: '<template><span><template scope="props"></template></span></template>',
65+
errors: ["'props' is defined but never used."]
66+
},
67+
{
68+
code: '<template><div v-for="i in 5"><comp v-for="j in 10">{{i}}{{i}}</comp></div></template>',
6569
errors: ["'j' is defined but never used."]
6670
},
6771
{

tests/lib/rules/valid-v-else-if.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ tester.run('valid-v-else-if', rule, {
4343
invalid: [
4444
{
4545
filename: 'test.vue',
46-
code: '<template v-else-if="foo"><div></div></template>',
46+
code: '<template><template v-else-if="foo"><div></div></template></template>',
4747
errors: ["'v-else-if' directives require being preceded by the element which has a 'v-if' or 'v-else-if' directive."]
4848
},
4949
{

tests/lib/rules/valid-v-else.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ tester.run('valid-v-else', rule, {
4343
invalid: [
4444
{
4545
filename: 'test.vue',
46-
code: '<template v-else><div></div></template>',
46+
code: '<template><template v-else><div></div></template></template>',
4747
errors: ["'v-else' directives require being preceded by the element which has a 'v-if' or 'v-else' directive."]
4848
},
4949
{

tests/lib/rules/valid-v-for.js

Lines changed: 37 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ tester.run('valid-v-for', rule, {
7777
},
7878
{
7979
filename: 'test.vue',
80-
code: '<template v-for="x of list"><slot name="item" /></template>'
80+
code: '<template><template v-for="x of list"><slot name="item" /></template></template>'
8181
},
8282
{
8383
filename: 'test.vue',
84-
code: '<template v-for="x of list">foo<div></div></template>'
84+
code: '<template><template v-for="x of list">foo<div></div></template></template>'
8585
},
8686
{
8787
filename: 'test.vue',
@@ -90,22 +90,26 @@ tester.run('valid-v-for', rule, {
9090
{
9191
filename: 'test.vue',
9292
code: `
93-
<template v-for="x in xs">
94-
<template v-for="y in x.ys">
95-
<li v-for="z in y.zs" :key="z.id">
96-
123
97-
</li>
93+
<template>
94+
<template v-for="x in xs">
95+
<template v-for="y in x.ys">
96+
<li v-for="z in y.zs" :key="z.id">
97+
123
98+
</li>
99+
</template>
98100
</template>
99101
</template>`
100102
},
101103
{
102104
filename: 'test.vue',
103105
code: `
104-
<template v-for="x in xs">
105-
<template v-for="y in ys">
106-
<li v-for="z in zs" :key="x.id + y.id + z.id">
107-
123
108-
</li>
106+
<template>
107+
<template v-for="x in xs">
108+
<template v-for="y in ys">
109+
<li v-for="z in zs" :key="x.id + y.id + z.id">
110+
123
111+
</li>
112+
</template>
109113
</template>
110114
</template>`
111115
}
@@ -215,38 +219,43 @@ tester.run('valid-v-for', rule, {
215219
filename: 'test.vue',
216220
errors: ["Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive."],
217221
code: `
218-
<template v-for="x in xs">
219-
<template v-for="y in a.ys">
220-
<li v-for="z in y.zs" :key="z.id">
221-
123
222-
</li>
222+
<template>
223+
<template v-for="x in xs">
224+
<template v-for="y in a.ys">
225+
<li v-for="z in y.zs" :key="z.id">
226+
123
227+
</li>
228+
</template>
223229
</template>
224230
</template>`
225231
},
226232
{
227233
filename: 'test.vue',
228234
errors: ["Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive."],
229235
code: `
230-
<template v-for="x in xs">
231-
<template v-for="y in x.ys">
232-
<li v-for="z in a.zs" :key="z.id">
233-
123
234-
</li>
236+
<template>
237+
<template v-for="x in xs">
238+
<template v-for="y in x.ys">
239+
<li v-for="z in a.zs" :key="z.id">
240+
123
241+
</li>
242+
</template>
235243
</template>
236244
</template>`
237245
},
238246
{
239247
filename: 'test.vue',
240248
errors: ["Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive."],
241249
code: `
242-
<template v-for="x in xs">
243-
<template v-for="y in x.ys">
244-
<li v-for="z in x.zs" :key="z.id">
245-
123
246-
</li>
250+
<template>
251+
<template v-for="x in xs">
252+
<template v-for="y in x.ys">
253+
<li v-for="z in x.zs" :key="z.id">
254+
123
255+
</li>
256+
</template>
247257
</template>
248258
</template>`
249259
}
250-
251260
]
252261
})

0 commit comments

Comments
 (0)