Skip to content

Commit c9b95af

Browse files
committed
Resolve merge conflict and update code according to PR#14661
Signed-off-by: Zijing Liu <[email protected]>
1 parent 4119531 commit c9b95af

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

vllm/v1/engine/async_llm.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,7 @@
2929
from vllm.v1.engine.parallel_sampling import ParentRequest
3030
from vllm.v1.engine.processor import Processor
3131
from vllm.v1.executor.abstract import Executor
32-
from vllm.v1.metrics.loggers import (PROMETHEUS_LOGGING_LOGGER_NAME,
33-
STANDARD_LOGGING_LOGGER_NAME,
34-
LoggingStatLogger, PrometheusStatLogger,
35-
StatLoggerBase)
32+
from vllm.v1.metrics.loggers import StatLoggerBase, setup_default_loggers
3633
from vllm.v1.metrics.stats import IterationStats, SchedulerStats
3734

3835
logger = init_logger(__name__)
@@ -64,11 +61,9 @@ def __init__(
6461
if stat_loggers is not None:
6562
self.stat_loggers = stat_loggers
6663
else:
67-
if logger.isEnabledFor(logging.INFO):
68-
self.stat_loggers[STANDARD_LOGGING_LOGGER_NAME] = (
69-
LoggingStatLogger())
70-
self.stat_loggers[PROMETHEUS_LOGGING_LOGGER_NAME] = (
71-
PrometheusStatLogger(vllm_config))
64+
setup_default_loggers(vllm_config,
65+
logger.isEnabledFor(logging.INFO),
66+
self.stat_loggers)
7267

7368
# Tokenizer (+ ensure liveness if running in another process).
7469
self.tokenizer = init_tokenizer_from_configs(

vllm/v1/metrics/loggers.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -431,3 +431,13 @@ def build_cudagraph_buckets(vllm_config: VllmConfig) -> list[int]:
431431
return buckets
432432
else:
433433
return [1, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8096]
434+
435+
436+
def setup_default_loggers(vllm_config: VllmConfig, enable_stats_log: bool,
437+
stat_loggers: dict[str, StatLoggerBase]):
438+
"""Setup logging and prometheus metrics."""
439+
stat_loggers[PROMETHEUS_LOGGING_LOGGER_NAME] = (
440+
PrometheusStatLogger(vllm_config))
441+
442+
if enable_stats_log:
443+
stat_loggers[STANDARD_LOGGING_LOGGER_NAME] = (LoggingStatLogger())

0 commit comments

Comments
 (0)