Skip to content

[Deprecation]: Remove legacy input mapper/processor from V0 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DarkLight1337 opened this issue Apr 27, 2025 · 3 comments · Fixed by #7
Closed

[Deprecation]: Remove legacy input mapper/processor from V0 #4

DarkLight1337 opened this issue Apr 27, 2025 · 3 comments · Fixed by #7
Assignees
@ilya-lavrenov

Comments

@DarkLight1337
Copy link
Member

Apply vllm-project/vllm#15686 to the model runner.

These methods should not be used anymore:

MultiModalRegistry.has_processor
MultiModalRegistry.create_input_mapper
MultiModalRegistry.init_mm_limits_per_prompt

I plan to remove those methods from upstream by v0.10.0
@DarkLight1337 DarkLight1337 changed the title [Deprecation]: Remove legacy/input mapper from V0 [Deprecation]: Remove legacy input mapper/processor from V0 Apr 27, 2025
@ilya-lavrenov
Copy link
Collaborator

OpenVINO backend does not use MultiModalRegistry at all.
I suppose we can close the ticket, right?

@ilya-lavrenov ilya-lavrenov self-assigned this Apr 28, 2025
@DarkLight1337
Copy link
Member Author

There are references to self.mm_registry inside the model runner

@ilya-lavrenov ilya-lavrenov mentioned this issue Apr 29, 2025
Merged
@ilya-lavrenov
Copy link
Collaborator

@DarkLight1337 thanks, please, have a look #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-lavrenov ilya-lavrenov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove legacy input mapper/processor from V0 ilya-lavrenov/vllm-openvino
2 participants
@ilya-lavrenov @DarkLight1337