Skip to content

Commit 02b0df3

Browse files
committed
Add stub for django.db.models.expressions.Expression.identity
I don't think we need to be very specific about the contents of the returned tuple; it's just used for comparison and hashing methods.
1 parent 2446b52 commit 02b0df3

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

django-stubs/db/models/expressions.pyi

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ class BaseExpression:
118118
def select_format(self, compiler: SQLCompiler, sql: str, params: _ParamsT) -> _AsSqlType: ...
119119
def get_expression_for_validation(self) -> BaseExpression: ...
120120

121-
class Expression(_Deconstructible, BaseExpression, Combinable): ...
121+
class Expression(_Deconstructible, BaseExpression, Combinable):
122+
def identity(self) -> tuple[Any, ...]: ...
122123

123124
class CombinedExpression(SQLiteNumericMixin, Expression):
124125
connector: str

django-stubs/db/models/lookups.pyi

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ class Lookup(Expression, Generic[_T]):
4141
def contains_aggregate(self) -> bool: ...
4242
@cached_property
4343
def contains_over_clause(self) -> bool: ...
44-
@property
45-
def identity(self) -> tuple[type[Lookup], Any, Any]: ...
4644

4745
class Transform(RegisterLookupMixin, Func):
4846
bilateral: bool

scripts/stubtest/allowlist_todo.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ django.contrib.gis.db.models.DurationField.formfield
173173
django.contrib.gis.db.models.DurationField.get_db_converters
174174
django.contrib.gis.db.models.EmailField.formfield
175175
django.contrib.gis.db.models.Exists.empty_result_set_value
176-
django.contrib.gis.db.models.Expression.identity
177176
django.contrib.gis.db.models.ExpressionWrapper.allowed_default
178177
django.contrib.gis.db.models.Extent.is_extent
179178
django.contrib.gis.db.models.Extent3D.is_extent
@@ -526,7 +525,6 @@ django.db.models.DurationField.formfield
526525
django.db.models.DurationField.get_db_converters
527526
django.db.models.EmailField.formfield
528527
django.db.models.Exists.empty_result_set_value
529-
django.db.models.Expression.identity
530528
django.db.models.ExpressionWrapper.allowed_default
531529
django.db.models.Field.__copy__
532530
django.db.models.Field.__deepcopy__
@@ -669,7 +667,6 @@ django.db.models.expressions.Func.allowed_default
669667
django.db.models.expressions.When.allowed_default
670668
django.db.models.expressions.Col.relabeled_clone
671669
django.db.models.expressions.Exists.empty_result_set_value
672-
django.db.models.expressions.Expression.identity
673670
django.db.models.expressions.OrderBy.as_oracle
674671
django.db.models.expressions.OrderBy.as_sql
675672
django.db.models.expressions.Ref.relabeled_clone

0 commit comments

Comments
 (0)