Merge remote-tracking branch 'upstream/master' into flake8_whatsnew21

* upstream/master:
  pct change bug issue 21200 (pandas-dev#21235)
  DOC: Fix summaries not ending with a period (pandas-dev#24190)
  DOC: Add back currentmodule to api.rst (pandas-dev#24232)
  DOC: Fixed implicit imports for whatsnew (v >= version 20.0) (pandas-dev#24199)
  remove enum import for PY2 compat, xref pandas-dev#22802 (pandas-dev#24170)
  CI: Simplify Azure Pipelines configuration files (pandas-dev#23111)
  REF/TST: Add more pytest idiom to indexing/multiindex/test_getitem.py (pandas-dev#24053)

Author: thoo

azure-pipelines.yml

@@ -1,28 +1,20 @@
 # Adapted from https://github.com/numba/numba/blob/master/azure-pipelines.yml
 jobs:
-# Mac and Linux could potentially use the same template
-# except it isn't clear how to use a different build matrix
-# for each, so for now they are separate
-- template: ci/azure/macos.yml
+# Mac and Linux use the same template
+- template: ci/azure/posix.yml
   parameters:
     name: macOS
     vmImage: xcode9-macos10.13
-- template: ci/azure/linux.yml
+- template: ci/azure/posix.yml
   parameters:
     name: Linux
     vmImage: ubuntu-16.04
 
-# Windows Python 2.7 needs VC 9.0 installed, and not sure
-# how to make that a conditional task, so for now these are
-# separate templates as well
+# Windows Python 2.7 needs VC 9.0 installed, handled in the template
 - template: ci/azure/windows.yml
   parameters:
     name: Windows
     vmImage: vs2017-win2016
-- template: ci/azure/windows-py27.yml
-  parameters:
-    name: WindowsPy27
-    vmImage: vs2017-win2016
 
 - job: 'Checks_and_doc'
   pool:

ci/azure/linux.yml

@@ -7,12 +7,30 @@ jobs:
   pool:
     vmImage: ${{ parameters.vmImage }}
   strategy:
-    maxParallel: 11
     matrix:
-      py35_np_120:
-        ENV_FILE: ci/deps/azure-macos-35.yaml
-        CONDA_PY: "35"
-        PATTERN: "not slow and not network"
+      ${{ if eq(parameters.name, 'macOS') }}:
+        py35_np_120:
+          ENV_FILE: ci/deps/azure-macos-35.yaml
+          CONDA_PY: "35"
+          PATTERN: "not slow and not network"
+
+      ${{ if eq(parameters.name, 'Linux') }}:
+        py27_np_120:
+          ENV_FILE: ci/deps/azure-27-compat.yaml
+          CONDA_PY: "27"
+          PATTERN: "not slow and not network"
+
+        py37_locale:
+          ENV_FILE: ci/deps/azure-37-locale.yaml
+          CONDA_PY: "37"
+          PATTERN: "not slow and not network"
+          LOCALE_OVERRIDE: "zh_CN.UTF-8"
+
+        py36_locale_slow:
+          ENV_FILE: ci/deps/azure-36-locale_slow.yaml
+          CONDA_PY: "36"
+          PATTERN: "not slow and not network"
+          LOCALE_OVERRIDE: "it_IT.UTF-8"
 
   steps:
     - script: |
@@ -39,7 +57,7 @@ jobs:
     - task: PublishTestResults@2
       inputs:
         testResultsFiles: 'test-data-*.xml'
-        testRunTitle: 'MacOS-35'
+        testRunTitle: ${{ format('{0}-$(CONDA_PY)', parameters.name) }}
     - powershell: |
         $junitXml = "test-data-single.xml"
         $(Get-Content $junitXml | Out-String) -match 'failures="(.*?)"'

ci/azure/macos.yml renamed to ci/azure/posix.yml

@@ -7,18 +7,28 @@ jobs:
   pool:
     vmImage: ${{ parameters.vmImage }}
   strategy:
-    maxParallel: 11
     matrix:
       py36_np14:
         ENV_FILE: ci/deps/azure-windows-36.yaml
         CONDA_PY: "36"
 
+      py27_np121:
+        ENV_FILE: ci/deps/azure-windows-27.yaml
+        CONDA_PY: "27"
+
   steps:
     - task: CondaEnvironment@1
       inputs:
         updateConda: no
         packageSpecs: ''
 
+    - powershell: |
+        $wc = New-Object net.webclient
+        $wc.Downloadfile("https://download.microsoft.com/download/7/9/6/796EF2E4-801B-4FC4-AB28-B59FBF6D907B/VCForPython27.msi", "VCForPython27.msi")
+        Start-Process "VCForPython27.msi" /qn -Wait
+      displayName: 'Install VC 9.0 only for Python 2.7'
+      condition: eq(variables.CONDA_PY, '27')
+
     - script: |
         ci\\incremental\\setup_conda_environment.cmd
       displayName: 'Before Install'
@@ -33,7 +43,7 @@ jobs:
     - task: PublishTestResults@2
       inputs:
         testResultsFiles: 'test-data.xml'
-        testRunTitle: 'Windows 36'
+        testRunTitle: 'Windows-$(CONDA_PY)'
     - powershell: |
         $junitXml = "test-data.xml"
         $(Get-Content $junitXml | Out-String) -match 'failures="(.*?)"'

ci/azure/windows-py27.yml

@@ -1,3 +1,9 @@
+.. The currentmodule is needed here because the autosummary generation of files
+.. happens before reading the files / substituting the header.
+.. See https://github.com/pandas-dev/pandas/pull/24232
+
+.. currentmodule:: pandas
+
 .. _api:
 
 {{ header }}

ci/azure/windows.yml

@@ -5,11 +5,6 @@ What's New in 0.23.1 (June 12, 2018)
 
 {{ header }}
 
-.. ipython:: python
-   :suppress:
-
-   from pandas import * # noqa F401, F403
-
 
 This is a minor bug-fix release in the 0.23.x series and includes some small regression fixes
 and bug fixes. We recommend that all users upgrade to this version.
@@ -43,19 +38,20 @@ To summarize, here's the behavior in 0.22.0, 0.23.0, 0.23.1:
 .. code-block:: python
 
    # 0.22.0... Silently coerce the datetime.date
-   >>> Series(pd.date_range('2017', periods=2)) == datetime.date(2017, 1, 1)
+   >>> import datetime
+   >>> pd.Series(pd.date_range('2017', periods=2)) == datetime.date(2017, 1, 1)
    0     True
    1    False
    dtype: bool
 
    # 0.23.0... Do not coerce the datetime.date
-   >>> Series(pd.date_range('2017', periods=2)) == datetime.date(2017, 1, 1)
+   >>> pd.Series(pd.date_range('2017', periods=2)) == datetime.date(2017, 1, 1)
    0    False
    1    False
    dtype: bool
 
    # 0.23.1... Coerce the datetime.date with a warning
-   >>> Series(pd.date_range('2017', periods=2)) == datetime.date(2017, 1, 1)
+   >>> pd.Series(pd.date_range('2017', periods=2)) == datetime.date(2017, 1, 1)
    /bin/python:1: FutureWarning: Comparing Series of datetimes with 'datetime.date'.  Currently, the
    'datetime.date' is coerced to a datetime. In the future pandas will
    not coerce, and the values not compare equal to the 'datetime.date'.

doc/source/api.rst

@@ -5,11 +5,6 @@ What's New in 0.23.2 (July 5, 2018)
 
 {{ header }}
 
-.. ipython:: python
-   :suppress:
-
-   from pandas import * # noqa F401, F403
-
 
 This is a minor bug-fix release in the 0.23.x series and includes some small regression fixes
 and bug fixes. We recommend that all users upgrade to this version.

doc/source/whatsnew/v0.23.1.rst

@@ -5,11 +5,6 @@ What's New in 0.23.4 (August 3, 2018)
 
 {{ header }}
 
-.. ipython:: python
-   :suppress:
-
-   from pandas import * # noqa F401, F403
-
 
 This is a minor bug-fix release in the 0.23.x series and includes some small regression fixes
 and bug fixes. We recommend that all users upgrade to this version.

doc/source/whatsnew/v0.23.2.rst

@@ -10,11 +10,6 @@ What's New in 0.24.0 (Month XX, 2018)
 
 {{ header }}
 
-.. ipython:: python
-   :suppress:
-
-   from pandas import * # noqa F401, F403
-
 
 These are the changes in pandas 0.24.0. See :ref:`release` for a full changelog
 including other versions of pandas.
@@ -387,6 +382,33 @@ Backwards incompatible API changes
 - :meth:`read_csv` will now raise a ``ValueError`` if a column with missing values is declared as having dtype ``bool`` (:issue:`20591`)
 - The column order of the resultant :class:`DataFrame` from :meth:`MultiIndex.to_frame` is now guaranteed to match the :attr:`MultiIndex.names` order. (:issue:`22420`)
 
+Percentage change on groupby changes
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+Fixed a bug where calling :func:`SeriesGroupBy.pct_change` or :func:`DataFrameGroupBy.pct_change` would previously work across groups when calculating the percent change, where it now correctly works per group (:issue:`21200`, :issue:`21235`).
+
+.. ipython:: python
+
+   df = pd.DataFrame({'grp': ['a', 'a', 'b'], 'foo': [1.0, 1.1, 2.2]})
+   df
+
+Previous behavior:
+
+.. code-block:: ipython
+
+   In [1]: df.groupby('grp').pct_change()
+   Out[1]:
+      foo
+   0  NaN
+   1  0.1
+   2  1.0
+
+New behavior:
+
+.. ipython:: python
+
+   df.groupby('grp').pct_change()
+
 .. _whatsnew_0240.api_breaking.deps:
 
 Dependencies have increased minimum versions