Skip to content

Commit b1b7b26

Browse files
allcontributors[bot]timdeschryver
authored andcommitted
docs: add mrtyagi07 as a contributor for doc (#1203)
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
1 parent 425d97a commit b1b7b26

File tree

3 files changed

+19
-9
lines changed

3 files changed

+19
-9
lines changed

.all-contributorsrc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2258,6 +2258,15 @@
22582258
"contributions": [
22592259
"doc"
22602260
]
2261+
},
2262+
{
2263+
"login": "mrtyagi07",
2264+
"name": "Vaibhav Tyagi",
2265+
"avatar_url": "https://avatars.githubusercontent.com/u/83115094?v=4",
2266+
"profile": "https://github.com/mrtyagi07",
2267+
"contributions": [
2268+
"doc"
2269+
]
22612270
}
22622271
],
22632272
"contributorsPerLine": 7,

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -455,6 +455,7 @@ Thanks goes to these wonderful people
455455
<td align="center" valign="top" width="14.28%"><a href="https://github.com/tnyo43"><img src="https://avatars.githubusercontent.com/u/11014018?v=4?s=100" width="100px;" alt="Tomoya Kashifuku"/><br /><sub><b>Tomoya Kashifuku</b></sub></a><br /><a href="https://github.com/testing-library/testing-library-docs/commits?author=tnyo43" title="Documentation">📖</a></td>
456456
<td align="center" valign="top" width="14.28%"><a href="https://leonerd.gatsbyjs.io/"><img src="https://avatars.githubusercontent.com/u/16910748?v=4?s=100" width="100px;" alt="Leo"/><br /><sub><b>Leo</b></sub></a><br /><a href="https://github.com/testing-library/testing-library-docs/commits?author=wtlin1228" title="Documentation">📖</a></td>
457457
<td align="center" valign="top" width="14.28%"><a href="http://spray-r.com"><img src="https://avatars.githubusercontent.com/u/69653055?v=4?s=100" width="100px;" alt="Erik Metz"/><br /><sub><b>Erik Metz</b></sub></a><br /><a href="https://github.com/testing-library/testing-library-docs/commits?author=erik-metz" title="Documentation">📖</a></td>
458+
<td align="center" valign="top" width="14.28%"><a href="https://github.com/mrtyagi07"><img src="https://avatars.githubusercontent.com/u/83115094?v=4?s=100" width="100px;" alt="Vaibhav Tyagi"/><br /><sub><b>Vaibhav Tyagi</b></sub></a><br /><a href="https://github.com/testing-library/testing-library-docs/commits?author=mrtyagi07" title="Documentation">📖</a></td>
458459
</tr>
459460
</tbody>
460461
</table>

docs/dom-testing-library/api-async.mdx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,14 @@ This can be useful if you have a unit test that mocks API calls and you need to
6565
wait for your mock promises to all resolve.
6666

6767
If you return a promise in the `waitFor` callback (either explicitly or
68-
implicitly with `async` syntax), then the `waitFor` utility will not call your
69-
callback again until that promise rejects. This allows you to `waitFor` things
70-
that must be checked asynchronously.
68+
implicitly with the `async` syntax), then the `waitFor` utility does not call
69+
your callback again until that promise rejects. This allows you to `waitFor`
70+
things that must be checked asynchronously.
7171

7272
The default `container` is the global `document`. Make sure the elements you
7373
wait for are descendants of `container`.
7474

75-
The default `interval` is `50ms`. However it will run your callback immediately
75+
The default `interval` is `50ms`. However it runs your callback immediately
7676
before starting the intervals.
7777

7878
The default `timeout` is `1000ms`.
@@ -83,9 +83,9 @@ what caused the timeout.
8383

8484
The default `mutationObserverOptions` is
8585
`{subtree: true, childList: true, attributes: true, characterData: true}` which
86-
will detect additions and removals of child elements (including text nodes) in
87-
the `container` and any of its descendants. It will also detect attribute
88-
changes. When any of those changes occur, it will re-run the callback.
86+
detects additions and removals of child elements (including text nodes) in the
87+
`container` and any of its descendants. It also detects attribute changes. When
88+
any of those changes occur, it re-runs the callback.
8989

9090
## `waitForElementToBeRemoved`
9191

@@ -125,8 +125,8 @@ el.parentElement.removeChild(el)
125125
// logs 'Element no longer in DOM'
126126
```
127127

128-
`waitForElementToBeRemoved` will throw an error if the first argument is `null`
129-
or an empty array:
128+
`waitForElementToBeRemoved` throws an error if the first argument is `null` or
129+
an empty array:
130130

131131
```javascript
132132
waitForElementToBeRemoved(null).catch(err => console.log(err))

0 commit comments

Comments
 (0)