Skip to content

Commit aeb7f4a

Browse files
committed
Prioritize aria names over hidden in byRole queries
1 parent 5bc9364 commit aeb7f4a

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/queries/role.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,6 @@ function queryAllByRole(
133133
// don't care if aria attributes are unspecified
134134
return true
135135
})
136-
.filter(element => {
137-
return hidden === false
138-
? isInaccessible(element, {
139-
isSubtreeInaccessible: cachedIsSubtreeInaccessible,
140-
}) === false
141-
: true
142-
})
143136
.filter(element => {
144137
if (name === undefined) {
145138
// Don't care
@@ -156,6 +149,13 @@ function queryAllByRole(
156149
text => text,
157150
)
158151
})
152+
.filter(element => {
153+
return hidden === false
154+
? isInaccessible(element, {
155+
isSubtreeInaccessible: cachedIsSubtreeInaccessible,
156+
}) === false
157+
: true
158+
})
159159
}
160160

161161
const getMultipleError = (c, role, {name} = {}) => {

0 commit comments

Comments
 (0)