Skip to content

[Bug] Tests Retry on "RST_STREAM with code 0/2 failing since Node 22.12.0 on Windows #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjameswh opened this issue Dec 16, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mjameswh
Copy link
Contributor

mjameswh commented Dec 16, 2024

Description

Integration tests Retry on "RST_STREAM with code 0" and Retry on "RST_STREAM with code 2" have started failing on Windows since Node v22.12.0.

I don't see anything obvious that would explain this in Node's release notes, and upgrading to latest release of @grpc/grpc-js didn't helped (I observed this issue with 1.10.10, 1.11.3 and 1.12.4).

Forcing CI to use Node v22.11.0 resolves the failure.

@mjameswh mjameswh added the bug Something isn't working label Dec 16, 2024
@mjameswh mjameswh changed the title [Bug] FILL_TITLE_HERE [Bug] Tests Retry on "RST_STREAM with code 0/2 failing in CI since Node 22.12.0 on Windows Dec 16, 2024
@mjameswh mjameswh changed the title [Bug] Tests Retry on "RST_STREAM with code 0/2 failing in CI since Node 22.12.0 on Windows [Bug] Tests Retry on "RST_STREAM with code 0/2 failing since Node 22.12.0 on Windows Dec 16, 2024
@mjameswh
Copy link
Contributor Author

For now, I'm just disabling these two tests on Windows, for Node releases 22.12.x...22.14.x. We'll revisit once we reach Node v23.15.0.

@mjameswh
Copy link
Contributor Author

This is very likely related due nodejs/node#56137.

@mjameswh
Copy link
Contributor Author

Fixed by #1586.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant