test: generate tmp work dirs

Generate tmp work directories for each new Tarantool instance. It
prevents possible directory clash issues.

Later `ioutil.TempDir` (deprecated since Go 1.17) must be replaced with
`os.MkdirTemp` (introduced in Go 1.16 as a replacement) when we drop
support of Go 1.16 an older.

Part of #215

Author: DifferentialOrange

connection_pool/connection_pool_test.go

@@ -2379,18 +2379,14 @@ func runTestMain(m *testing.M) int {
 	waitStart := 100 * time.Millisecond
 	connectRetry := 3
 	retryTimeout := 500 * time.Millisecond
-	workDirs := []string{
-		"work_dir1", "work_dir2",
-		"work_dir3", "work_dir4",
-		"work_dir5"}
 
 	// Tarantool supports streams and interactive transactions since version 2.10.0
 	isStreamUnsupported, err := test_helpers.IsTarantoolVersionLess(2, 10, 0)
 	if err != nil {
 		log.Fatalf("Could not check the Tarantool version")
 	}
 
-	instances, err = test_helpers.StartTarantoolInstances(servers, workDirs, test_helpers.StartOpts{
+	instances, err = test_helpers.StartTarantoolInstances(servers, test_helpers.StartOpts{
 		InitScript:         initScript,
 		User:               connOpts.User,
 		Pass:               connOpts.Pass,

datetime/datetime_test.go

@@ -1141,7 +1141,6 @@ func runTestMain(m *testing.M) int {
 	instance, err := test_helpers.StartTarantool(test_helpers.StartOpts{
 		InitScript:   "config.lua",
 		Listen:       server,
-		WorkDir:      "work_dir",
 		User:         opts.User,
 		Pass:         opts.Pass,
 		WaitStart:    100 * time.Millisecond,

decimal/decimal_test.go

@@ -613,7 +613,6 @@ func runTestMain(m *testing.M) int {
 	instance, err := test_helpers.StartTarantool(test_helpers.StartOpts{
 		InitScript:   "config.lua",
 		Listen:       server,
-		WorkDir:      "work_dir",
 		User:         opts.User,
 		Pass:         opts.Pass,
 		WaitStart:    100 * time.Millisecond,

multi/multi_test.go

@@ -592,7 +592,6 @@ func runTestMain(m *testing.M) int {
 	inst1, err := test_helpers.StartTarantool(test_helpers.StartOpts{
 		InitScript:         initScript,
 		Listen:             server1,
-		WorkDir:            "work_dir1",
 		User:               connOpts.User,
 		Pass:               connOpts.Pass,
 		WaitStart:          waitStart,
@@ -609,7 +608,6 @@ func runTestMain(m *testing.M) int {
 	inst2, err := test_helpers.StartTarantool(test_helpers.StartOpts{
 		InitScript:   initScript,
 		Listen:       server2,
-		WorkDir:      "work_dir2",
 		User:         connOpts.User,
 		Pass:         connOpts.Pass,
 		WaitStart:    waitStart,

queue/queue_test.go

@@ -899,7 +899,6 @@ func runTestMain(m *testing.M) int {
 	inst, err := test_helpers.StartTarantool(test_helpers.StartOpts{
 		InitScript:   "testdata/config.lua",
 		Listen:       server,
-		WorkDir:      "work_dir",
 		User:         opts.User,
 		Pass:         opts.Pass,
 		WaitStart:    100 * time.Millisecond,
@@ -913,15 +912,14 @@ func runTestMain(m *testing.M) int {
 
 	defer test_helpers.StopTarantoolWithCleanup(inst)
 
-	workDirs := []string{"work_dir1", "work_dir2"}
 	poolOpts := test_helpers.StartOpts{
 		InitScript:   "testdata/pool.lua",
 		User:         opts.User,
 		Pass:         opts.Pass,
 		WaitStart:    3 * time.Second, // replication_timeout * 3
 		ConnectRetry: -1,
 	}
-	instances, err = test_helpers.StartTarantoolInstances(serversPool, workDirs, poolOpts)
+	instances, err = test_helpers.StartTarantoolInstances(serversPool, poolOpts)
 
 	if err != nil {
 		log.Fatalf("Failed to prepare test tarantool pool: %s", err)

ssl_test.go

@@ -126,7 +126,6 @@ func serverTnt(serverOpts, clientOpts SslOpts) (test_helpers.TarantoolInstance,
 		ClientServer:    tntHost,
 		ClientTransport: "ssl",
 		ClientSsl:       clientOpts,
-		WorkDir:         "work_dir_ssl",
 		User:            "test",
 		Pass:            "test",
 		WaitStart:       100 * time.Millisecond,

tarantool_test.go

@@ -23,7 +23,6 @@ import (
 var startOpts test_helpers.StartOpts = test_helpers.StartOpts{
 	InitScript:   "config.lua",
 	Listen:       server,
-	WorkDir:      "work_dir",
 	User:         opts.User,
 	Pass:         opts.Pass,
 	WaitStart:    100 * time.Millisecond,
@@ -3317,7 +3316,6 @@ func TestConnection_NewWatcher_reconnect(t *testing.T) {
 	inst, err := test_helpers.StartTarantool(test_helpers.StartOpts{
 		InitScript:   "config.lua",
 		Listen:       server,
-		WorkDir:      "work_dir",
 		User:         opts.User,
 		Pass:         opts.Pass,
 		WaitStart:    100 * time.Millisecond,

test_helpers/main.go

@@ -47,12 +47,6 @@ type StartOpts struct {
 	// a Tarantool instance.
 	ClientSsl tarantool.SslOpts
 
-	// WorkDir is box.cfg work_dir parameter for tarantool.
-	// Specify folder to store tarantool data files.
-	// Folder must be unique for each tarantool process used simultaneously.
-	// https://www.tarantool.io/en/doc/latest/reference/configuration/#confval-work_dir
-	WorkDir string
-
 	// SslCertsDir is a path to a directory with SSL certificates. It will be
 	// copied to the working directory.
 	SslCertsDir string
@@ -84,6 +78,10 @@ type TarantoolInstance struct {
 	// Cmd is a Tarantool command. Used to kill Tarantool process.
 	Cmd *exec.Cmd
 
+	// WorkDir is box.cfg work_dir parameter for Tarantool.
+	// https://www.tarantool.io/en/doc/latest/reference/configuration/#confval-work_dir
+	WorkDir string
+
 	// Options for restarting a tarantool instance.
 	Opts StartOpts
 }
@@ -189,30 +187,28 @@ func RestartTarantool(inst *TarantoolInstance) error {
 func StartTarantool(startOpts StartOpts) (TarantoolInstance, error) {
 	// Prepare tarantool command.
 	var inst TarantoolInstance
+
+	// Create work_dir for a new instance.
+	// TO DO: replace with `os.MkdirTemp` when we drop support of
+	// Go 1.16 an older
+	dir, err := ioutil.TempDir("", "work_dir")
+	if err != nil {
+		return inst, err
+	}
+	inst.WorkDir = dir
+
 	inst.Cmd = exec.Command("tarantool", startOpts.InitScript)
 
 	inst.Cmd.Env = append(
 		os.Environ(),
-		fmt.Sprintf("TEST_TNT_WORK_DIR=%s", startOpts.WorkDir),
+		fmt.Sprintf("TEST_TNT_WORK_DIR=%s", inst.WorkDir),
 		fmt.Sprintf("TEST_TNT_LISTEN=%s", startOpts.Listen),
 		fmt.Sprintf("TEST_TNT_MEMTX_USE_MVCC_ENGINE=%t", startOpts.MemtxUseMvccEngine),
 	)
 
-	// Clean up existing work_dir.
-	err := os.RemoveAll(startOpts.WorkDir)
-	if err != nil {
-		return inst, err
-	}
-
-	// Create work_dir.
-	err = os.Mkdir(startOpts.WorkDir, 0755)
-	if err != nil {
-		return inst, err
-	}
-
 	// Copy SSL certificates.
 	if startOpts.SslCertsDir != "" {
-		err = copySslCerts(startOpts.WorkDir, startOpts.SslCertsDir)
+		err = copySslCerts(inst.WorkDir, startOpts.SslCertsDir)
 		if err != nil {
 			return inst, err
 		}
@@ -289,8 +285,8 @@ func StopTarantool(inst TarantoolInstance) {
 func StopTarantoolWithCleanup(inst TarantoolInstance) {
 	StopTarantool(inst)
 
-	if inst.Opts.WorkDir != "" {
-		if err := os.RemoveAll(inst.Opts.WorkDir); err != nil {
+	if inst.WorkDir != "" {
+		if err := os.RemoveAll(inst.WorkDir); err != nil {
 			log.Fatalf("Failed to clean work directory, got %s", err)
 		}
 	}

test_helpers/pool_helper.go

@@ -218,16 +218,11 @@ func SetClusterRO(servers []string, connOpts tarantool.Opts, roles []bool) error
 	return nil
 }
 
-func StartTarantoolInstances(servers []string, workDirs []string, opts StartOpts) ([]TarantoolInstance, error) {
-	if len(servers) != len(workDirs) {
-		return nil, fmt.Errorf("number of servers should be equal to number of workDirs")
-	}
-
+func StartTarantoolInstances(servers []string, opts StartOpts) ([]TarantoolInstance, error) {
 	instances := make([]TarantoolInstance, 0, len(servers))
 
-	for i, server := range servers {
+	for _, server := range servers {
 		opts.Listen = server
-		opts.WorkDir = workDirs[i]
 
 		instance, err := StartTarantool(opts)
 		if err != nil {

uuid/uuid_test.go

@@ -155,7 +155,6 @@ func runTestMain(m *testing.M) int {
 	inst, err := test_helpers.StartTarantool(test_helpers.StartOpts{
 		InitScript:   "config.lua",
 		Listen:       server,
-		WorkDir:      "work_dir",
 		User:         opts.User,
 		Pass:         opts.Pass,
 		WaitStart:    100 * time.Millisecond,