Skip to content

Commit 903b091

Browse files
committed
code health: place fill* functions in the beginning of the files
File `requests.go` has `fill*` functions as well as `prepare.go` file. We should sync with `requests.go` and place `fill*` functions in the beginning of `prepare.go` file. Follows up #101
1 parent e1bb59c commit 903b091

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

prepared.go

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,26 @@ type Prepared struct {
1919
Conn *Connection
2020
}
2121

22+
func fillPrepare(enc *msgpack.Encoder, expr string) error {
23+
enc.EncodeMapLen(1)
24+
enc.EncodeUint64(KeySQLText)
25+
return enc.EncodeString(expr)
26+
}
27+
28+
func fillUnprepare(enc *msgpack.Encoder, stmt Prepared) error {
29+
enc.EncodeMapLen(1)
30+
enc.EncodeUint64(KeyStmtID)
31+
return enc.EncodeUint64(uint64(stmt.StatementID))
32+
}
33+
34+
func fillExecutePrepared(enc *msgpack.Encoder, stmt Prepared, args interface{}) error {
35+
enc.EncodeMapLen(2)
36+
enc.EncodeUint64(KeyStmtID)
37+
enc.EncodeUint64(uint64(stmt.StatementID))
38+
enc.EncodeUint64(KeySQLBind)
39+
return encodeSQLBind(enc, args)
40+
}
41+
2242
// NewPreparedFromResponse constructs a Prepared object.
2343
func NewPreparedFromResponse(conn *Connection, resp *Response) (*Prepared, error) {
2444
if resp == nil {
@@ -116,23 +136,3 @@ func (req *ExecutePreparedRequest) Args(args interface{}) *ExecutePreparedReques
116136
func (req *ExecutePreparedRequest) Body(res SchemaResolver, enc *msgpack.Encoder) error {
117137
return fillExecutePrepared(enc, *req.stmt, req.args)
118138
}
119-
120-
func fillPrepare(enc *msgpack.Encoder, expr string) error {
121-
enc.EncodeMapLen(1)
122-
enc.EncodeUint64(KeySQLText)
123-
return enc.EncodeString(expr)
124-
}
125-
126-
func fillUnprepare(enc *msgpack.Encoder, stmt Prepared) error {
127-
enc.EncodeMapLen(1)
128-
enc.EncodeUint64(KeyStmtID)
129-
return enc.EncodeUint64(uint64(stmt.StatementID))
130-
}
131-
132-
func fillExecutePrepared(enc *msgpack.Encoder, stmt Prepared, args interface{}) error {
133-
enc.EncodeMapLen(2)
134-
enc.EncodeUint64(KeyStmtID)
135-
enc.EncodeUint64(uint64(stmt.StatementID))
136-
enc.EncodeUint64(KeySQLBind)
137-
return encodeSQLBind(enc, args)
138-
}

0 commit comments

Comments
 (0)