Skip to content

Drop error_marshaling_enabled session setting #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #2960
Totktonada opened this issue Nov 9, 2021 · 3 comments · Fixed by #3618
Closed
Tracked by #2960

Drop error_marshaling_enabled session setting #2415

Totktonada opened this issue Nov 9, 2021 · 3 comments · Fixed by #3618
Assignees
Labels
2.10 behavior change [nature] Сhange in existing behavior deprecation [nature] Deprecated functionality errors

Comments

@Totktonada
Copy link
Member

Totktonada commented Nov 9, 2021

Product: Tarantool
Since: 2.10.0-beta1-46-g0cdf5f9be89c
Root document: pages where the error_marshaling_enabled setting is mentioned:

SME: @ locker

Details

box.session.setting.error_marshaling_enabled was used to enable encoding
errors returned by CALL/EVAL in the extended format (as the MP_ERROR
MsgPack extension). Now, the feature is enabled automatically if the
connector supports it (sets IPROTO_FEATURE_ERROR_EXTENSION in IPROTO_ID
features).

Requested by @locker in tarantool/tarantool@0cdf5f9

Related to #2416

@Totktonada
Copy link
Member Author

Totktonada commented Nov 9, 2021

I'll also highlight that #1676 is not resolved.

@veod32
Copy link
Collaborator

veod32 commented Dec 24, 2021

@Totktonada A few questions to estimate the issue:

Now, the feature is enabled automatically if the connector supports it...

What happens if the connector doesn't support it? Old behavior and usage of box.session.setting.error_marshaling_enabled is still there and possible in such cases?

  1. Since which Tarantool version do we have this new behavior?

@veod32 veod32 added server [area] Task relates to Tarantool's server (core) functionality behavior change [nature] Сhange in existing behavior labels Dec 24, 2021
@locker
Copy link
Member

locker commented Dec 24, 2021

What happens if the connector doesn't support it?

Errors returned from CALL/EVAL (return box.error(...)) will be converted to strings, as before.

Old behavior and usage of box.session.setting.error_marshaling_enabled is still there and possible in such cases?

It was dropped. No such setting anymore.

  1. Since which Tarantool version do we have this new behavior?
$ git describe 0cdf5f9be89c5ec71a34968dfa84b4485bf20d14
2.10.0-beta1-46-g0cdf5f9be89c

@veod32 veod32 added the deprecation [nature] Deprecated functionality label Dec 24, 2021
@veod32 veod32 changed the title Drop error_marshaling_enabled session setting [2pt] Drop error_marshaling_enabled session setting Dec 24, 2021
@veod32 veod32 removed this from the Estimate [@veod32] milestone Dec 24, 2021
@veod32 veod32 added this to the error milestone Jan 13, 2022
@xuniq xuniq removed the 2sp label Dec 14, 2022
@veod32 veod32 added errors 2.10 and removed server [area] Task relates to Tarantool's server (core) functionality labels Mar 6, 2023
@veod32 veod32 removed this from the error milestone Mar 6, 2023
@veod32 veod32 changed the title [2pt] Drop error_marshaling_enabled session setting Drop error_marshaling_enabled session setting Mar 6, 2023
@andreyaksenov andreyaksenov self-assigned this Aug 15, 2023
@andreyaksenov andreyaksenov linked a pull request Aug 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.10 behavior change [nature] Сhange in existing behavior deprecation [nature] Deprecated functionality errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants