Update files after review

Author: xuniq

doc/dev_guide/reference_capi/box.rst

@@ -251,7 +251,8 @@
 
     Since version :doc:`2.11.0 </release/2.11.0>`.
     Send an :ref:`IPROTO <internals-iproto-format>` packet over the session's socket with the given MsgPack header
-    and body. NB: yields.
+    and body.
+    The function yields.
     The function works for binary sessions only. For details, see :ref:`box.session.type() <box_session-type>`.
 
     :param uint32_t     sid: IPROTO session identifier (see :ref:`box_session_id() <box_box_session_id>`)
@@ -261,25 +262,49 @@
     :param char*     body_end: end of a body encoded as MsgPack
 
     :return: 0 on success
-    :return: 1 if there is a failure
+    :return: -1 on error (check :ref:`box_error_last() <c_api-error-box_error_last>`)
     :rtype: number
 
     See also :ref:`box.iproto.send() <reference_lua-box_iproto_send>`
 
+    **Possible errors:**
+
+    *   :errcode:`ER_SESSION_CLOSED` -- the session is closed.
+    *   :errcode:`ER_NO_SUCH_SESSION` -- the session does not exist.
+    *   :errcode:`ER_MEMORY_ISSUE` -- out of memory limit has been reached.
+    *   :errcode:`ER_WRONG_SESSION_TYPE` -- the session type is not binary.
+
+    For details, see `src/box/errcode.h <https://github.com/tarantool/tarantool/blob/master/src/box/errcode.h>`__.
+
 ..  _box_box_iproto_override:
 
 ..  c:function:: void box_iproto_override(uint32_t request_type, iproto_handler_t handler, iproto_handler_destroy_t destroy, void *ctx)
 
     Since version :doc:`2.11.0 </release/2.11.0>`.
     Sets an IPROTO request handler with the provided context for the given request type.
+    The function yields.
+
+Possible values:
 
-    :param uint32_t     request_type: request type code from the ``iproto_type`` enumeration
-    :param iproto_handler_t     handler: IPROTO request handler
+                                *   a type code from the :ref:`box.iproto.type <reference_lua-box_iproto_type>` (except
+                                    ``box.iproto.type.UNKNOWN``) -- override the existing request type.
+
+                                *   ``box.iproto.type.UNKNOWN`` -- override an unknown request type.
+
+    :param uint32_t request_type: request type code from the ``iproto_type`` enumeration
+    :param iproto_handler_t handler: IPROTO request handler
     :param iproto_handler_destroy_t destroy: IPROTO request handler destructor
-    :param void*    ctx: context passed to handler
+    :param void* ctx: a context passed to the ``handler`` and ``destroy`` callbacks
 
     :return: 0 on success
     :return: -1 on error (check :ref:`box_error_last() <c_api-error-box_error_last>`)
     :rtype: number
 
-    See also :ref:`box.session.id() <box_session-id>`
+    See also :ref:`box.iproto.override() <reference_lua-box_iproto_override>`
+
+    **Possible errors:**
+
+    *   :errcode:`ER_PROC_LUA` -- the exception is thrown, diagnostic is not set.
+    *   diagnostics from ``src/box/errcode.h`` -- the exception is thrown, diagnostic is set.
+
+    For details, see `src/box/errcode.h <https://github.com/tarantool/tarantool/blob/master/src/box/errcode.h>`__.

doc/reference/reference_lua/box_iproto.rst

@@ -9,7 +9,7 @@ The ``box.iproto`` submodule provides the ability to work with the network subsy
 It enables to extend the :ref:`binary protocol <box_protocol>` functionality from the Lua libraries.
 With this submodule, you can:
 
-*   parse the unknown IPROTO requests
+*   :ref:`parse the unknown IPROTO requests types <reference_lua-box_iproto_override>`
 *   :ref:`send arbitrary IPROTO packets <reference_lua-box_iproto_send>`
 *   :ref:`override the behavior <reference_lua-box_iproto_override>` of the existing request types in binary protocol
 
@@ -73,7 +73,7 @@ The example converts the feature names from the ``box.iproto.protocol_features``
     watchers = true,
     }
 
-    -- Конвертация имен фич в коды, чтобы вернуть их в ответ на запрос IPROTO_ID.
+    -- Convert the feature names into codes
     features = {}
     for name in pairs(box.iproto.protocol_features) do
         table.insert(features, box.iproto.feature[name])
@@ -128,7 +128,7 @@ The table lists all available functions and data of the submodule:
             - IPROTO protocol :ref:`features <internals-iproto-keys-features>`
 
          *  - :doc:`./box_iproto/override`
-            - Set the IPROTO request handler callbacks
+            - Set an IPROTO request handler callbacks for the given request type
 
          *  - :doc:`./box_iproto/send`
             - Send an IPROTO packet over the session's socket

doc/reference/reference_lua/box_iproto/override.rst

@@ -3,18 +3,58 @@
 box.iproto.override()
 =====================
 
+function(header, body) end
+-- @param header userdata @ заголовок запроса в виде msgpack_object
+--                          (см. модуль msgpack)
+-- @param body userdata @ тело запроса в виде msgpack_object
+--                        (см. модуль msgpack)
+-- @a header и @a body можно дополнительно индексировать по IPROTO константам
+-- такого же формата как в box.iproto (то есть, в любом регистре без префикса
+-- IPROTO).
+-- @return boolean @ true, если успех, false для фоллбека на системный обработчик
+function(header, body) end
+
+---
+-- Перегружает обработчик запроса заданного типа.
+-- `box.iproto.type.UNKNOWN` перегружает обработчик неизвестных типов запросов.
+-- @param request_type number @ тип обработчика
+-- @param handler function @ пользователський обработчик; nil сбрасывает обработчик
+-- @return nil
+function box.iproto.override(request_type, handler) end
+
 ..  module:: box.iproto
 
 ..  function:: override(request_type, handler)
 
     Since version :doc:`2.11.0 </release/2.11.0>`.
-    Set the IPROTO request handler callbacks.
+    Set a new IPROTO request handler callback for the given request type.
+
+    :param number request_type: a request type code. Possible values:
+
+                                *   a type code from the :ref:`box.iproto.type <reference_lua-box_iproto_type>` (except
+                                    ``box.iproto.type.UNKNOWN``) -- override the existing request type.
+
+                                *   ``box.iproto.type.UNKNOWN`` -- override an unknown request type.
+
+
+    :param function handler: IPROTO request handler. To reset the request handler, pass ``nill``.
+
+                             The handler function has the following syntax:
+                             ``function(header, body) end``.
+
+                             :param userdata header: a header of the request encoded as :ref:`msgpack_object <msgpack-object-methods>`
+                             :param userdata body: a body of the request encoded as :ref:`msgpack_object <msgpack-object-methods>`
+                             :return: true on success
+                             :rtype: boolean
+
+    :rtype: nil
+
+    **Possible errors:**
 
-    :param uint32_t     request_type:
-    :param iproto_handler_t     handler:
+    *   :errcode:`ER_PROC_LUA` -- the exception is thrown, diagnostic is not set.
+    *   diagnostics from ``src/box/errcode.h`` -- the exception is thrown, diagnostic is set.
 
-    :return: 0 on success or -1 on error (check box_error_last())
-    :rtype: number
+    For details, see `src/box/errcode.h <https://github.com/tarantool/tarantool/blob/master/src/box/errcode.h>`__.
 
     **Example:**
 

doc/reference/reference_lua/box_iproto/protocol_features.rst

@@ -8,7 +8,7 @@ box.iproto.protocol_features
 ..  data:: protocol_features
 
     The set of IPROTO protocol features supported by the server.
-    Learn more: `src/box/iproto_features.h <https://github.com/tarantool/tarantool/blob/master/src/box/iproto_features.h>`__
+    Learn more: :ref:`net.box features <net_box-connect>`, `src/box/iproto_features.h <https://github.com/tarantool/tarantool/blob/master/src/box/iproto_features.h>`__,
     and `iproto_features_resolve() <https://github.com/tarantool/tarantool/blob/dec0e0221e183fa972efa65bb0fb658112f2196f/src/box/lua/net_box.lua#L93-L105>`__.
 
 **Example**

doc/reference/reference_lua/box_iproto/send.rst

@@ -1,4 +1,4 @@
-.. _reference_lua-box_iproto_send:
+..  _reference_lua-box_iproto_send:
 
 box.iproto.send()
 =================
@@ -10,17 +10,36 @@ box.iproto.send()
     Since version :doc:`2.11.0 </release/2.11.0>`.
     Send an :ref:`IPROTO <internals-iproto-format>` packet over the session's socket with the given MsgPack header
     and body.
+    The header and body contain exported IPROTO constants from the :ref:`box.iproto() <box_iproto>` submodule.
+    Possible IPROTO constant formats:
+
+    *   lower case constant without the ``IPROTO_`` prefix (``schema_version``, ``request_type``)
+    *   constant from the corresponding :ref:`box.iproto <box_iproto>` subnamespace (``box.iproto.SCHEMA_VERSION``, ``box.iproto.REQUEST_TYPE``)
+
+    The function works for binary sessions only. For details, see :ref:`box.session.type() <box_session-type>`.
 
     :param number sid: IPROTO session identifier (see :ref:`box.session.id() <box_session-id>`)
     :param table|string header: a request header encoded as MsgPack
     :param table|string|nil body: a request body encoded as MsgPack
 
-    :return: 0 on success
-    :return: 1 on error
+    :return: 0 on success, otherwise an error is raised
     :rtype: number
 
     **Possible errors:**
 
-    **Example:**
+    *   :errcode:`ER_SESSION_CLOSED` -- the session is closed.
+    *   :errcode:`ER_NO_SUCH_SESSION` -- the session does not exist.
+    *   :errcode:`ER_MEMORY_ISSUE` -- out of memory limit has been reached.
+    *   :errcode:`ER_WRONG_SESSION_TYPE` -- the session type is not binary.
+
+    For details, see `src/box/errcode.h <https://github.com/tarantool/tarantool/blob/master/src/box/errcode.h>`__.
+
+**Example:**
+
+..  code-block:: lua
+
+
+
+