Skip to content
This repository was archived by the owner on Apr 13, 2021. It is now read-only.

Commit 2ec0ee1

Browse files
committed
Address review comments.
1 parent 97af952 commit 2ec0ee1

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/baseline.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,8 +409,9 @@ static bool chi_test(double threshold, u8 num_dds,
409409
*
410410
* -`-1`: < 3 dds
411411
* -`-2`: dgelsy error (see lesq_solution_float)
412-
* -`-3`: raim check failed, repair failed
412+
* -`-3`: raim check failed, repair failed, ref satellite was bad
413413
* -`-4`: raim check failed, not enough sats for repair
414+
* -`-5`: raim check failed, repair failed, more than one acceptable solution
414415
*/
415416
/* TODO(dsk) update all call sites to use n_used as calculated here.
416417
* TODO(dsk) add warn/info logging to call sites when repair occurs.

src/track.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -784,13 +784,13 @@ s8 calc_navigation_measurement(u8 n_channels, const channel_measurement_t *meas[
784784
/* Compute the time of transmit of the signal on the satellite from the
785785
* tracking loop parameters. This will be used to compute the pseudorange. */
786786
nav_meas[i]->tot.tow = 1e-3 * meas[i]->time_of_week_ms;
787-
nav_meas[i]->tot.tow += meas[i]->code_phase_chips / 1.023e6;
788-
nav_meas[i]->tot.tow -= meas[i]->rec_time_delta * meas[i]->code_phase_rate / 1.023e6;
787+
nav_meas[i]->tot.tow += meas[i]->code_phase_chips / GPS_CA_CHIPPING_RATE;
788+
nav_meas[i]->tot.tow -= meas[i]->rec_time_delta * meas[i]->code_phase_rate / GPS_CA_CHIPPING_RATE;
789789
/* For now use the week number from the ephemeris. */
790790
/* TODO: Should we use a more reliable source for the week number? */
791791
/* TODO (Leith): There might be a bug where ephmeris ToW is set to 0 */
792792
/* near end of the week, without ToW being rolled over? */
793-
/* It woukd this functions' assumptions to break. */
793+
/* It would cause this functions' assumptions to break. */
794794
gps_time_match_weeks(&nav_meas[i]->tot, &e[i]->toe);
795795

796796
/* Compute the carrier phase measurement. */
@@ -820,7 +820,7 @@ s8 calc_navigation_measurement(u8 n_channels, const channel_measurement_t *meas[
820820
/* If we were given a time, use that. */
821821
tor = *rec_time;
822822
} else {
823-
/* If we were not given a recieve time then we can just set one of the
823+
/* If we were not given a time of reception then we can just set one of the
824824
* pseudoranges aribtrarily to a nominal value and reference all the other
825825
* pseudoranges to that. This doesn't affect the PVT solution but does
826826
* potentially correspond to a large receiver clock error. */
@@ -870,7 +870,7 @@ int nav_meas_cmp(const void *a, const void *b)
870870
* \param n_old Number of measurements in `m_old`
871871
* \param m_old Array of old navigation measurements, sorted by PRN
872872
* \param m_corrected Array in which to store the output measurements
873-
* \param dt The difference in receiver time betweeb the two measurements
873+
* \param dt The difference in receiver time between the two measurements
874874
* \return The number of measurements written to `m_tdcp`
875875
*/
876876
u8 tdcp_doppler(u8 n_new, navigation_measurement_t *m_new,

0 commit comments

Comments
 (0)