Skip to content

Commit 11399b9

Browse files
author
Dani Reinón
committed
chore: add "_" to internal methods
1 parent cfe8e38 commit 11399b9

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

postgrest_py/base_request_builder.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def raise_when_api_error(cls: Type[APIResponse], value: Any) -> Any:
9898
return value
9999

100100
@staticmethod
101-
def get_count_from_content_range_header(
101+
def _get_count_from_content_range_header(
102102
content_range_header: str,
103103
) -> Optional[int]:
104104
content_range = content_range_header.split("/")
@@ -107,32 +107,32 @@ def get_count_from_content_range_header(
107107
return int(content_range[1])
108108

109109
@staticmethod
110-
def is_count_in_prefer_header(prefer_header: str) -> bool:
110+
def _is_count_in_prefer_header(prefer_header: str) -> bool:
111111
pattern = f"count=({'|'.join([cm.value for cm in CountMethod])})"
112112
return bool(search(pattern, prefer_header))
113113

114114
@classmethod
115-
def get_count_from_http_request_response(
115+
def _get_count_from_http_request_response(
116116
cls: Type[APIResponse],
117117
request_response: RequestResponse,
118118
) -> Optional[int]:
119119
prefer_header: Optional[str] = request_response.request.headers.get("prefer")
120120
if not prefer_header:
121121
return None
122-
is_count_in_prefer_header = cls.is_count_in_prefer_header(prefer_header)
122+
is_count_in_prefer_header = cls._is_count_in_prefer_header(prefer_header)
123123
content_range_header: Optional[str] = request_response.headers.get(
124124
"content-range"
125125
)
126126
if not (is_count_in_prefer_header and content_range_header):
127127
return None
128-
return cls.get_count_from_content_range_header(content_range_header)
128+
return cls._get_count_from_content_range_header(content_range_header)
129129

130130
@classmethod
131131
def from_http_request_response(
132132
cls: Type[APIResponse], request_response: RequestResponse
133133
) -> APIResponse:
134134
data = request_response.json()
135-
count = cls.get_count_from_http_request_response(request_response)
135+
count = cls._get_count_from_http_request_response(request_response)
136136
return cls(data=data, count=count)
137137

138138

tests/_async/test_request_builder.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def test_get_count_from_content_range_header_with_count(
248248
self, content_range_header_with_count: str
249249
):
250250
assert (
251-
APIResponse.get_count_from_content_range_header(
251+
APIResponse._get_count_from_content_range_header(
252252
content_range_header_with_count
253253
)
254254
== 2
@@ -258,23 +258,23 @@ def test_get_count_from_content_range_header_without_count(
258258
self, content_range_header_without_count: str
259259
):
260260
assert (
261-
APIResponse.get_count_from_content_range_header(
261+
APIResponse._get_count_from_content_range_header(
262262
content_range_header_without_count
263263
)
264264
is None
265265
)
266266

267267
def test_is_count_in_prefer_header_true(self, prefer_header_with_count: str):
268-
assert APIResponse.is_count_in_prefer_header(prefer_header_with_count)
268+
assert APIResponse._is_count_in_prefer_header(prefer_header_with_count)
269269

270270
def test_is_count_in_prefer_header_false(self, prefer_header_without_count: str):
271-
assert not APIResponse.is_count_in_prefer_header(prefer_header_without_count)
271+
assert not APIResponse._is_count_in_prefer_header(prefer_header_without_count)
272272

273273
def test_get_count_from_http_request_response_without_prefer_header(
274274
self, request_response_without_prefer_header: Response
275275
):
276276
assert (
277-
APIResponse.get_count_from_http_request_response(
277+
APIResponse._get_count_from_http_request_response(
278278
request_response_without_prefer_header
279279
)
280280
is None
@@ -284,7 +284,7 @@ def test_get_count_from_http_request_response_with_prefer_header_without_count(
284284
self, request_response_with_prefer_header_without_count: Response
285285
):
286286
assert (
287-
APIResponse.get_count_from_http_request_response(
287+
APIResponse._get_count_from_http_request_response(
288288
request_response_with_prefer_header_without_count
289289
)
290290
is None
@@ -294,7 +294,7 @@ def test_get_count_from_http_request_response_with_count_and_content_range(
294294
self, request_response_with_prefer_header_with_count_and_content_range: Response
295295
):
296296
assert (
297-
APIResponse.get_count_from_http_request_response(
297+
APIResponse._get_count_from_http_request_response(
298298
request_response_with_prefer_header_with_count_and_content_range
299299
)
300300
== 2

tests/_sync/test_request_builder.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def test_get_count_from_content_range_header_with_count(
248248
self, content_range_header_with_count: str
249249
):
250250
assert (
251-
APIResponse.get_count_from_content_range_header(
251+
APIResponse._get_count_from_content_range_header(
252252
content_range_header_with_count
253253
)
254254
== 2
@@ -258,23 +258,23 @@ def test_get_count_from_content_range_header_without_count(
258258
self, content_range_header_without_count: str
259259
):
260260
assert (
261-
APIResponse.get_count_from_content_range_header(
261+
APIResponse._get_count_from_content_range_header(
262262
content_range_header_without_count
263263
)
264264
is None
265265
)
266266

267267
def test_is_count_in_prefer_header_true(self, prefer_header_with_count: str):
268-
assert APIResponse.is_count_in_prefer_header(prefer_header_with_count)
268+
assert APIResponse._is_count_in_prefer_header(prefer_header_with_count)
269269

270270
def test_is_count_in_prefer_header_false(self, prefer_header_without_count: str):
271-
assert not APIResponse.is_count_in_prefer_header(prefer_header_without_count)
271+
assert not APIResponse._is_count_in_prefer_header(prefer_header_without_count)
272272

273273
def test_get_count_from_http_request_response_without_prefer_header(
274274
self, request_response_without_prefer_header: Response
275275
):
276276
assert (
277-
APIResponse.get_count_from_http_request_response(
277+
APIResponse._get_count_from_http_request_response(
278278
request_response_without_prefer_header
279279
)
280280
is None
@@ -284,7 +284,7 @@ def test_get_count_from_http_request_response_with_prefer_header_without_count(
284284
self, request_response_with_prefer_header_without_count: Response
285285
):
286286
assert (
287-
APIResponse.get_count_from_http_request_response(
287+
APIResponse._get_count_from_http_request_response(
288288
request_response_with_prefer_header_without_count
289289
)
290290
is None
@@ -294,7 +294,7 @@ def test_get_count_from_http_request_response_with_count_and_content_range(
294294
self, request_response_with_prefer_header_with_count_and_content_range: Response
295295
):
296296
assert (
297-
APIResponse.get_count_from_http_request_response(
297+
APIResponse._get_count_from_http_request_response(
298298
request_response_with_prefer_header_with_count_and_content_range
299299
)
300300
== 2

0 commit comments

Comments
 (0)