Skip to content

Spring Java format does not work anymore with Checkstyle later than 10.21.4 #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michael-simons opened this issue Apr 28, 2025 · 3 comments

Comments

@michael-simons
Copy link

In

<module name="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck">
you are using the scope property. Checkstyle 10.22 / 10.23 does complain it does not exists, see an example here:

https://github.com/neo4j/neo4j-jdbc/actions/runs/14700014966/job/41247756236?pr=928#step:9:76

@wilkinsona
Copy link
Contributor

#433 should have taken care of this. Please try 0.0.44-SNAPSHOT (available from https://repo.spring.io/snapshot). If you still have a problem, please comment on #433 so that we can investigate.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2025
@michael-simons
Copy link
Author

Oh, my bad, should have looked at the closed issues, too.

Tested with Checkstyle 10.23.1, Java format 0.0.44 snapshot, can confirm works again as expected.

I do not envy you folks templating that stuff, thank you for it though. 🙇

@wilkinsona
Copy link
Contributor

😀 I don't really like templating it either, but the Checkstyle schema/DTD doesn't allow placeholders for property names (only property values). Resorting to some templating and pre-processing before the XML's parsed seemed like the least bad option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants