Skip to content

Wire.begin() should not be used within a library #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coelner opened this issue Dec 10, 2018 · 2 comments
Closed

Wire.begin() should not be used within a library #13

coelner opened this issue Dec 10, 2018 · 2 comments

Comments

@coelner
Copy link

coelner commented Dec 10, 2018

The Wire.begin() call is bad because it resets the bus. It should only be called by the upper instance. If the user defined other pins for I2C these pins get lost.

See here: esp8266/Arduino#2607

@nseidle
Copy link
Member

nseidle commented Dec 10, 2018

Agreed. And the whole thing should be re-written to not hard-code the wire port.

@nseidle
Copy link
Member

nseidle commented Dec 11, 2018

Fixed in v1.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants