[REFACTOR] Change {List-type property} to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)

Author: Gonzalo Diaz

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/arrays/NewYearChaos.Test.cs

@@ -5,11 +5,26 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.a
 [TestClass]
 public class NewYearChaosTest
 {
-  public class NewYearChaosTestCase
+  public class NewYearChaosTestCase(string title, int[] input, string expected)
   {
-    public string title { get; set; } = default!;
-    public List<int> input { get; set; } = default!;
-    public string expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<int> input = [.. input];
+    private readonly string expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<int> Input
+    {
+      get { return input; }
+    }
+
+    public string Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<NewYearChaosTestCase> testCases { get; set; } = default!;
@@ -29,10 +44,10 @@ public void testMinimumBribesText()
 
     foreach (NewYearChaosTestCase test in testCases)
     {
-      result = NewYearChaos.minimumBribesText(test.input);
-      NewYearChaos.minimumBribes(test.input);
+      result = NewYearChaos.minimumBribesText(test.Input);
+      NewYearChaos.minimumBribes(test.Input);
 
-      Assert.AreEqual(test.expected, result);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/CountTriplets.Test.cs

@@ -5,12 +5,32 @@ namespace algorithm_exercises_csharp_test.hackerrank.interview_preparation_kit.d
 [TestClass]
 public class CountTripletsTest
 {
-  public class CountTripletsTestCase
+  public class CountTripletsTestCase(string title, long[] input, int r, long expected)
   {
-    public string title { get; set; } = default!;
-    public List<long> input { get; set; } = default!;
-    public int r { get; set; } = default!;
-    public long expected { get; set; } = default!;
+    private readonly string title = title;
+    private readonly List<long> input = [.. input];
+    private readonly int r = r;
+    private readonly long expected = expected;
+
+    public string Title
+    {
+      get { return title; }
+    }
+
+    public List<long> Input
+    {
+      get { return input; }
+    }
+
+    public int R
+    {
+      get { return r; }
+    }
+
+    public long Expected
+    {
+      get { return expected; }
+    }
   }
 
   private List<CountTripletsTestCase> testCases { get; set; } = default!;
@@ -35,14 +55,14 @@ public void testCountTriplets()
 
     foreach (CountTripletsTestCase test in testCases)
     {
-      result = CountTriplets.countTriplets(test.input, test.r);
-      Assert.AreEqual(test.expected, result);
+      result = CountTriplets.countTriplets(test.Input, test.R);
+      Assert.AreEqual(test.Expected, result);
     }
 
     foreach (CountTripletsTestCase test in bigTestCases)
     {
-      result = CountTriplets.countTriplets(test.input, test.r);
-      Assert.AreEqual(test.expected, result);
+      result = CountTriplets.countTriplets(test.Input, test.R);
+      Assert.AreEqual(test.Expected, result);
     }
   }
 }