Skip to content

Commit 545f012

Browse files
committed
Fix tooltip init after review
Previous code passed a jQuery collection which initTooltip couldn't handle. Instead, iterate the individial matched elements and add a dollar to the variable name to make it clear it's jQuery. Fixes: go-gitea#20809
1 parent 82f89ff commit 545f012

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

web_src/js/features/repo-diff.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,18 +50,21 @@ export function initRepoDiffConversationForm() {
5050
return;
5151
}
5252

53-
const newConversationHolder = $(await $.post(form.attr('action'), form.serialize()));
54-
const {path, side, idx} = newConversationHolder.data();
53+
const $newConversationHolder = $(await $.post(form.attr('action'), form.serialize()));
54+
const {path, side, idx} = $newConversationHolder.data();
5555

56-
initTooltip(newConversationHolder.find('.tooltip'));
57-
form.closest('.conversation-holder').replaceWith(newConversationHolder);
56+
$newConversationHolder.find('.tooltip').each(function () {
57+
initTooltip(this);
58+
});
59+
60+
form.closest('.conversation-holder').replaceWith($newConversationHolder);
5861
if (form.closest('tr').data('line-type') === 'same') {
5962
$(`[data-path="${path}"] a.add-code-comment[data-idx="${idx}"]`).addClass('invisible');
6063
} else {
6164
$(`[data-path="${path}"] a.add-code-comment[data-side="${side}"][data-idx="${idx}"]`).addClass('invisible');
6265
}
63-
newConversationHolder.find('.dropdown').dropdown();
64-
initCompReactionSelector(newConversationHolder);
66+
$newConversationHolder.find('.dropdown').dropdown();
67+
initCompReactionSelector($newConversationHolder);
6568
});
6669

6770

0 commit comments

Comments
 (0)