Skip to content

parse_ipv6addr: add some bounds checking on indexes #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucab opened this issue May 10, 2017 · 1 comment
Closed

parse_ipv6addr: add some bounds checking on indexes #334

lucab opened this issue May 10, 2017 · 1 comment

Comments

@lucab
Copy link

lucab commented May 10, 2017

Capturing my comment from #294 (comment).

parse_ipv6addr does a bit of index juggling when decompressing input, and it may benefit from some bound checking to ensure no index underflow/overflow will induce a panic there at runtime.

This exists in current master here, but it is likely going to be changed by #294.

@lucab lucab changed the title parse_ipv6addr: add some bounds checking on indexed parse_ipv6addr: add some bounds checking on indexes May 10, 2017
@SimonSapin
Copy link
Member

Closing as this doesn’t seem very actionable. Please comment here or open a new issue if there is a specific test case that panics where it shouldn’t.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants