Skip to content

Commit deeeafc

Browse files
committed
De-duplicate url parser percent encoding constants with those defined in percent_encoding.
1 parent feb7a3a commit deeeafc

File tree

2 files changed

+5
-22
lines changed

2 files changed

+5
-22
lines changed

url/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ pub use form_urlencoded;
134134
extern crate serde;
135135

136136
use crate::host::HostInternal;
137-
use crate::parser::{to_u32, Context, Parser, SchemeType, PATH_SEGMENT, USERINFO};
138-
use percent_encoding::{percent_decode, percent_encode, utf8_percent_encode};
137+
use crate::parser::{to_u32, Context, Parser, SchemeType, PATH_SEGMENT};
138+
use percent_encoding::{percent_decode, percent_encode, utf8_percent_encode, USERINFO};
139139
use std::borrow::Borrow;
140140
use std::cmp;
141141
use std::fmt::{self, Write};

url/src/parser.rs

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,26 +13,9 @@ use std::str;
1313
use crate::host::{Host, HostInternal};
1414
use crate::Url;
1515
use form_urlencoded::EncodingOverride;
16-
use percent_encoding::{percent_encode, utf8_percent_encode, AsciiSet, CONTROLS};
17-
18-
/// https://url.spec.whatwg.org/#fragment-percent-encode-set
19-
const FRAGMENT: &AsciiSet = &CONTROLS.add(b' ').add(b'"').add(b'<').add(b'>').add(b'`');
20-
21-
/// https://url.spec.whatwg.org/#path-percent-encode-set
22-
const PATH: &AsciiSet = &FRAGMENT.add(b'#').add(b'?').add(b'{').add(b'}');
23-
24-
/// https://url.spec.whatwg.org/#userinfo-percent-encode-set
25-
pub(crate) const USERINFO: &AsciiSet = &PATH
26-
.add(b'/')
27-
.add(b':')
28-
.add(b';')
29-
.add(b'=')
30-
.add(b'@')
31-
.add(b'[')
32-
.add(b'\\')
33-
.add(b']')
34-
.add(b'^')
35-
.add(b'|');
16+
use percent_encoding::{
17+
percent_encode, utf8_percent_encode, AsciiSet, CONTROLS, FRAGMENT, PATH, USERINFO,
18+
};
3619

3720
pub(crate) const PATH_SEGMENT: &AsciiSet = &PATH.add(b'/').add(b'%');
3821

0 commit comments

Comments
 (0)