Skip to content

Commit 077075b

Browse files
authored
Merge pull request #853 from lucacasonato/move_url_debugger_to_separate_crate
Move debugger_visualizer tests to separate crate
2 parents a3e07c7 + 4b31c13 commit 077075b

File tree

5 files changed

+34
-12
lines changed

5 files changed

+34
-12
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
if: |
4747
matrix.os == 'windows-latest' &&
4848
matrix.rust == 'nightly'
49-
run: cargo test --test debugger_visualizer --features "url/serde,url/debugger_visualizer" -- --test-threads=1
49+
run: cargo test --test debugger_visualizer --features "url/debugger_visualizer,url_debug_tests/debugger_visualizer" -- --test-threads=1
5050
- name: Test `no_std` support
5151
run: cargo test --no-default-features --features=alloc
5252

Cargo.toml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,9 @@
11
[workspace]
2-
members = ["url", "form_urlencoded", "idna", "percent_encoding", "data-url"]
2+
members = [
3+
"url",
4+
"form_urlencoded",
5+
"idna",
6+
"percent_encoding",
7+
"data-url",
8+
"url_debug_tests",
9+
]

url/Cargo.toml

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,12 @@ appveyor = { repository = "Manishearth/rust-url" }
2323
[dev-dependencies]
2424
serde_json = "1.0"
2525
bencher = "0.1"
26-
# To test debugger visualizers defined for the url crate such as url.natvis
27-
debugger_test = "0.1"
28-
debugger_test_parser = "0.1"
2926

3027
[dependencies]
3128
form_urlencoded = { version = "1.2.0", path = "../form_urlencoded" }
3229
idna = { version = "0.4.0", path = "../idna" }
3330
percent-encoding = { version = "2.3.0", path = "../percent_encoding" }
34-
serde = {version = "1.0", optional = true, features = ["derive"]}
31+
serde = { version = "1.0", optional = true, features = ["derive"] }
3532

3633
[features]
3734
default = []
@@ -46,12 +43,6 @@ name = "parse_url"
4643
path = "benches/parse_url.rs"
4744
harness = false
4845

49-
[[test]]
50-
name = "debugger_visualizer"
51-
path = "tests/debugger_visualizer.rs"
52-
required-features = ["debugger_visualizer"]
53-
test = false
54-
5546
[package.metadata.docs.rs]
5647
features = ["serde"]
5748

url_debug_tests/Cargo.toml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
[package]
2+
3+
name = "url_debug_tests"
4+
version = "0.0.0"
5+
description = "Tests for debugger visualizers defined for the url crate such as url.natvis"
6+
publish = false
7+
rust-version = "1.60"
8+
9+
[dev-dependencies]
10+
url = { path = "../url" }
11+
debugger_test = "0.1"
12+
debugger_test_parser = "0.1"
13+
14+
[features]
15+
debugger_visualizer = []
16+
17+
[[test]]
18+
name = "debugger_visualizer"
19+
path = "tests/debugger_visualizer.rs"
20+
required-features = ["debugger_visualizer"]
21+
test = false

url/tests/debugger_visualizer.rs renamed to url_debug_tests/tests/debugger_visualizer.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
extern crate debugger_test;
2+
extern crate url;
3+
14
use debugger_test::debugger_test;
25
use url::Url;
36

0 commit comments

Comments
 (0)