-
Notifications
You must be signed in to change notification settings - Fork 580
Allow the ryu
dependency be opt-out
#474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the suggestion. The original C implementation my ryu crate is based on is dual licensed Apache 2.0 + Boost 1.0. Would it help if I make the ryu Rust code available under Boost 1.0? Boost is strictly less restrictive than MIT i.e. Boost is identical to MIT except that when distributing only "machine-executable object code generated by a source language processor" then there are no obligations whatsoever. I am not a lawyer but that seems like any MIT-only reverse dependency would be able to satisfy the terms of the Boost license. |
Alternatively we could reach out to the original authors asking to make their code available to us under the terms of the MIT license. |
Law-wise I think following the original license choice ( I raised this issue because it triggered rustc's license checker. So even with the license change, the tools would still need to know that BSL is compatible with MIT. |
Done in ryu 0.2.6. Let's leave this issue open until the legal stuff is sorted on rustc's end. |
I am not sure whether this is still moving or who is responsible for following up in the license checker tool, so I'll give this a close. Let me know if there is anything more needed on my end. |
ryu
is Apache-2.0 which may be unacceptable for a MIT-only reverse dependency.We could make
ryu
optional (and required by thearbitrary_precision
feature), and makewrite_f32
/write_f64
use the standard library's formatter whenryu
is not used.The text was updated successfully, but these errors were encountered: