nicla-system: Move function to read LDO register to pmic driver.

Author: sebromero

libraries/Nicla_System/src/BQ25120A.cpp

@@ -25,6 +25,11 @@ uint8_t BQ25120A::getFastChargeControlRegister()
   return readByte(BQ25120A_ADDRESS, BQ25120A_FAST_CHG);
 }
 
+uint8_t BQ25120A::getLDOControlRegister()
+{
+  return readByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL);
+}
+
 void BQ25120A::writeByte(uint8_t address, uint8_t subAddress, uint8_t data)
 {
   setHighImpedanceModeEnabled(false);

libraries/Nicla_System/src/BQ25120A.h

@@ -41,6 +41,14 @@ class BQ25120A
    */
   uint8_t getFaultsRegister();
 
+  /**
+   * @brief Gets the data from the SYS VOUT Control Register.
+   * @see Section 9.6.7 of the datasheet.
+   * 
+   * @return uint8_t The data from the SYS VOUT Control Register.
+   */
+  uint8_t getLDOControlRegister();
+
   /**
    * @brief Gets the data from the fast charge control register.
    * @see Section 9.6.4 of the datasheet.

libraries/Nicla_System/src/Nicla_System.cpp

@@ -65,7 +65,7 @@ bool nicla::enable3V3LDO()
 {
   uint8_t ldo_reg = 0xE4;
   _pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL, ldo_reg);
-  if (_pmic.readByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL) != ldo_reg) {
+  if (_pmic.getLDOControlRegister() != ldo_reg) {
     return false;
   }
   return true;
@@ -75,18 +75,18 @@ bool nicla::enable1V8LDO()
 {
   uint8_t ldo_reg = 0xA8;
   _pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL, ldo_reg);
-  if (_pmic.readByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL) != ldo_reg) {
+  if (_pmic.getLDOControlRegister() != ldo_reg) {
     return false;
   }
   return true;
 }
 
 bool nicla::disableLDO()
 {
-  uint8_t ldo_reg = _pmic.readByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL);
+  uint8_t ldo_reg = _pmic.getLDOControlRegister();
   ldo_reg &= 0x7F;
   _pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL, ldo_reg);
-  if (_pmic.readByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL) != ldo_reg) {
+  if (_pmic.getLDOControlRegister() != ldo_reg) {
     return false;
   }
   return true;
@@ -103,11 +103,6 @@ bool nicla::enterShipMode()
   _pmic.writeByte(BQ25120A_ADDRESS, BQ25120A_STATUS, status_reg);
 }
 
-uint8_t nicla::readLDOreg()
-{
-  return _pmic.readByte(BQ25120A_ADDRESS, BQ25120A_LDO_CTRL);
-}
-
 bool nicla::enableCharge(uint8_t mA, bool disableNtc)
 {
 

libraries/Nicla_System/src/Nicla_System.h

@@ -51,7 +51,6 @@ class nicla {
    * @return true if the ship mode is entered successfully.
    */
   static bool enterShipMode();
-  static uint8_t readLDOreg();
   static bool enableCharge(uint8_t mA = 20, bool disableNtc = true);
 
   /**