-
-
Notifications
You must be signed in to change notification settings - Fork 13
feat(getSegments): custom highlighter #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
scriptcoded
merged 6 commits into
scriptcoded:master
from
mediabakery:custom-highlighter
Aug 8, 2022
Merged
feat(getSegments): custom highlighter #57
scriptcoded
merged 6 commits into
scriptcoded:master
from
mediabakery:custom-highlighter
Aug 8, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scriptcoded
requested changes
Aug 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thank you for the contribution! 🎉
Also thanks for taking on issues, I don't have too much time myself. I like your implementation and just have some smaller comments and suggestions.
Hey @scriptcoded, |
scriptcoded
added a commit
that referenced
this pull request
Aug 8, 2022
This reverts commit 8150d15.
Released in v4.2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides a few minor adjustments, the functionality for generating segments from a SQL string has been transferred to a stand-alone function
getSegments
. Thus, it is possible to write your own highlighter. see #6