Skip to content

Fix number regex #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

Fix number regex #41

merged 1 commit into from
Jul 26, 2022

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Jun 23, 2022

Avoid fields, tables with numbers,
Examples:

SELECT f1, f2, f3, -1, 1, "1", 1.00 FROM t1;

Result:
image
Result with this PR:
image

@scriptcoded
Copy link
Owner

Thank you! Could you please add a test or two to cover these cases?

@erikn69
Copy link
Contributor Author

erikn69 commented Jul 25, 2022

Done

@scriptcoded scriptcoded merged commit a6d1fd6 into scriptcoded:master Jul 26, 2022
@github-actions github-actions bot mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikn69 @scriptcoded