You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe error messages tests should be dropped, unless they test something really specific.
E.g. a way information is represented that is easy to break.
For normal tests we have check files, or (most of the time even better) `// error` annotations.
The problem with over-engineered solutions like error messages tests is that they cause a huge
friction when things change. I lost an inordinate amount of time getting the extensions PR
over the line since in the meantime there landed an elaborate error messages commit. Fixing rebase
breakages over this PR is not a good use of my time! Two things could improve that situation:
- we go slower on inessential PRs like error messages, _in particular_ if there is a pending
conflict with a pending PR
- we go faster merging essential PRs.
0 commit comments