Restore AugmentScala2Traits, but limit it to super accessors.

Author: sjrd

compiler/src/dotty/tools/dotc/Compiler.scala

@@ -86,7 +86,7 @@ class Compiler {
          new LiftTry,                // Put try expressions that might execute on non-empty stacks into their own methods
          new CollectNullableFields,  // Collect fields that can be nulled out after use in lazy initialization
          new ElimOuterSelect,        // Expand outer selections
-         //new AugmentScala2Traits,    // Augments Scala2 traits with additional members needed for mixin composition.
+         new AugmentScala2Traits,    // Augments Scala2 traits so that super accessors are made non-private
          new ResolveSuper,           // Implement super accessors
          new FunctionXXLForwarders,  // Add forwarders for FunctionXXL apply method
          new ParamForwarding,        // Add forwarders for aliases of superclass parameters

compiler/src/dotty/tools/dotc/transform/AugmentScala2Traits.scala

@@ -20,14 +20,12 @@ object AugmentScala2Traits {
   val name: String = "augmentScala2Traits"
 }
 
-/** This phase augments Scala2 traits with additional members needed for mixin composition.
+/** This phase augments Scala2 traits to fix up super accessors.
  *
- *  These symbols would have been added between Unpickling and Mixin in the Scala2 pipeline.
+ *  Strangely, Scala 2 super accessors are pickled as private, but are compiled as public expanded.
+ *  In this phase we expand them and make them non-private, so that `ResolveSuper` does something meaningful.
  *
- *  Specifically, we:
- *   - Add trait setters for vals defined in traits.
- *   - Expand the names of all private getters and setters as well as super accessors in the trait and make
- *     not-private.
+ *  TODO Should we merge this into `ResolveSuper` at this point?
  */
 class AugmentScala2Traits extends MiniPhase with IdentityDenotTransformer { thisPhase =>
   import ast.tpd._
@@ -47,21 +45,8 @@ class AugmentScala2Traits extends MiniPhase with IdentityDenotTransformer { this
   }
 
   private def augmentScala2Trait(mixin: ClassSymbol)(implicit ctx: Context): Unit = {
-    def traitSetter(getter: TermSymbol) =
-      getter.copy(
-        name = getter.ensureNotPrivate.name
-          .expandedName(getter.owner, TraitSetterName)
-          .asTermName.setterName,
-        flags = Method | Accessor,
-        info = MethodType(getter.info.resultType :: Nil, defn.UnitType))
-
     for (sym <- mixin.info.decls) {
-      if (sym.isGetter && !sym.isOneOf(DeferredOrLazy) && !sym.setter.exists &&
-          !sym.info.resultType.isInstanceOf[ConstantType])
-        traitSetter(sym.asTerm).enteredAfter(thisPhase)
-      if ((sym.isAllOf(PrivateAccessor) && !sym.name.is(ExpandedName) &&
-        (sym.isGetter || sym.isSetter)) // strangely, Scala 2 fields are also methods that have Accessor set.
-        || sym.isSuperAccessor) // scala2 superaccessors are pickled as private, but are compiled as public expanded
+      if (sym.isSuperAccessor)
         sym.ensureNotPrivate.installAfter(thisPhase)
     }
     mixin.setFlagFrom(thisPhase, Scala2xPartiallyAugmented)

compiler/src/dotty/tools/dotc/transform/ResolveSuper.scala

@@ -34,7 +34,7 @@ class ResolveSuper extends MiniPhase with IdentityDenotTransformer { thisPhase =
   override def phaseName: String = ResolveSuper.name
 
   override def runsAfter: Set[String] = Set(ElimByName.name, // verified empirically, need to figure out what the reason is.
-                               //AugmentScala2Traits.name,
+                               AugmentScala2Traits.name,
                                PruneErasedDefs.name) // Erased decls make `isCurrent` work incorrectly
 
   override def changesMembers: Boolean = true // the phase adds super accessors