Error msg/stable identifiers (#5334)

* stable identifier message

* stable identifiers test

* assert message text

* rewrite error message

Author: Hermes Espínola González

compiler/src/dotty/tools/dotc/reporting/diagnostic/ErrorMessageID.java

@@ -141,7 +141,8 @@ public enum ErrorMessageID {
     LazyStaticFieldID,
     StaticOverridingNonStaticMembersID,
     OverloadInRefinementID,
-    NoMatchingOverloadID
+    NoMatchingOverloadID,
+    StableIdentPatternID
     ;
 
     public int errorNumber() {

compiler/src/dotty/tools/dotc/reporting/diagnostic/messages.scala

@@ -2191,4 +2191,11 @@ object messages {
     val kind: String = "Type Mismatch"
     val explanation: String = ""
   }
+  case class StableIdentPattern(tree: untpd.Tree, pt: Type)(implicit val ctx: Context)
+    extends Message(StableIdentPatternID) {
+    override def kind: String = "Syntax"
+    override def msg: String =
+      hl"""Stable identifier required, but ${tree.show} found"""
+    override def explanation: String = ""
+  }
 }

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -414,7 +414,7 @@ class Typer extends Namer
         !pt.isInstanceOf[ApplyingProto] &&
         !tree.tpe.isStable &&
         !isWildcardArg(tree))
-      ctx.error(s"stable identifier required, but ${tree.show} found", tree.pos)
+      ctx.error(StableIdentPattern(tree, pt), tree.pos)
 
     tree
   }

compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala

@@ -1605,4 +1605,24 @@ class ErrorMessagesTests extends ErrorMessagesTest {
         message.msg
       )
     }
+
+    @Test def StableIdentifiers() =
+      checkMessagesAfter(FrontEnd.name) {
+        """
+          | object Test {
+          |   var x = 2
+          |   def test = 2 match {
+          |     case `x` => x + 1
+          |   }
+          | }
+        """.stripMargin
+      }.expect { (_, messages) =>
+        assertMessageCount(1, messages)
+        val message = messages.head
+        assertTrue(message.isInstanceOf[StableIdentPattern])
+        assertEquals(
+          "Stable identifier required, but `x` found",
+          message.msg
+        )
+      }
 }