Skip to content

Commit 4ff676e

Browse files
authored
bugfix: Exclude newer LSP4j, which is built on JDK 11 (#20771)
It seems the CI started failing because of out bump, but that was not picked up aside from windows tests weirdly. Metals recently updated to newest LSP4j, though I think nothing new was added and no changes were done to the presentation compiler so we should be ok to downgrade locally: https://github.com/scalameta/metals/pull/6126/files The update was mostly done so that we done fall behind in the LSP standard, but this might become a problem in the future here. Do we ever plan do drop supporting JDK 8?
2 parents cf55fba + 790bee9 commit 4ff676e

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

project/Build.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1356,8 +1356,10 @@ object Build {
13561356
libraryDependencies ++= Seq(
13571357
"org.lz4" % "lz4-java" % "1.8.0",
13581358
"io.get-coursier" % "interface" % "1.0.18",
1359-
"org.scalameta" % "mtags-interfaces" % mtagsVersion,
1360-
"com.google.guava" % "guava" % "33.2.1-jre"
1359+
("org.scalameta" % "mtags-interfaces" % mtagsVersion)
1360+
.exclude("org.eclipse.lsp4j","org.eclipse.lsp4j")
1361+
.exclude("org.eclipse.lsp4j","org.eclipse.lsp4j.jsonrpc"),
1362+
"org.eclipse.lsp4j" % "org.eclipse.lsp4j" % "0.20.1",
13611363
),
13621364
libraryDependencies += ("org.scalameta" % "mtags-shared_2.13.12" % mtagsVersion % SourceDeps),
13631365
ivyConfigurations += SourceDeps.hide,

0 commit comments

Comments
 (0)