The qual of This could be Ident

liufengyun · liufengyun · commit 45febea1a350 · 2020-07-21T21:39:41.000+02:00
We should check the type instead,
which is more semantic.
diff --git a/compiler/src/dotty/tools/dotc/transform/TreeChecker.scala b/compiler/src/dotty/tools/dotc/transform/TreeChecker.scala
@@ -414,7 +414,7 @@ class TreeChecker extends Phase with SymTransformer {
     }
 
     override def typedSuper(tree: untpd.Super, pt: Type)(using Context): Tree =
-      assert(tree.qual.isInstanceOf[untpd.This], i"expect prefix of Super to be This, actual = ${tree.qual}")
+      assert(tree.qual.tpe.isInstanceOf[ThisType], i"expect prefix of Super to be This, actual = ${tree.qual}")
       super.typedSuper(tree, pt)
 
     private def checkOwner(tree: untpd.Tree)(using Context): Unit = {

Original file line number	Diff line number	Diff line change
`@@ -414,7 +414,7 @@ class TreeChecker extends Phase with SymTransformer {`
`414`	`414`	`}`
`415`	`415`
`416`	`416`	`override def typedSuper(tree: untpd.Super, pt: Type)(using Context): Tree =`
`417`		`- assert(tree.qual.isInstanceOf[untpd.This], i"expect prefix of Super to be This, actual = ${tree.qual}")`
	`417`	`+ assert(tree.qual.tpe.isInstanceOf[ThisType], i"expect prefix of Super to be This, actual = ${tree.qual}")`
`418`	`418`	`super.typedSuper(tree, pt)`
`419`	`419`
`420`	`420`	`private def checkOwner(tree: untpd.Tree)(using Context): Unit = {`