Merge pull request #2225 from dotty-staging/fix-#2192

Fix #2212: Avoid imports in the wrong namespace

Author: odersky

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -179,6 +179,20 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
           previous
         }
 
+      def selection(imp: ImportInfo, name: Name) =
+        if (imp.sym.isCompleting) {
+          ctx.warning(i"cyclic ${imp.sym}, ignored", tree.pos)
+          NoType
+        } else if (unimported.nonEmpty && unimported.contains(imp.site.termSymbol))
+          NoType
+        else {
+          val pre = imp.site
+          val denot = pre.member(name).accessibleFrom(pre)(refctx)
+            // Pass refctx so that any errors are reported in the context of the
+            // reference instead of the
+          if (reallyExists(denot)) pre.select(name, denot) else NoType
+        }
+
       /** The type representing a named import with enclosing name when imported
        *  from given `site` and `selectors`.
        */
@@ -194,25 +208,15 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
               found
             }
 
-            def selection(name: Name) =
-              if (imp.sym.isCompleting) {
-                ctx.warning(i"cyclic ${imp.sym}, ignored", tree.pos)
-                NoType
-              }
-              else if (unimported.nonEmpty && unimported.contains(imp.site.termSymbol))
-                NoType
-              else {
-                // Pass refctx so that any errors are reported in the context of the
-                // reference instead of the
-                checkUnambiguous(selectionType(imp.site, name, tree.pos)(refctx))
-              }
+            def unambiguousSelection(name: Name) =
+              checkUnambiguous(selection(imp, name))
 
             selector match {
               case Thicket(fromId :: Ident(Name) :: _) =>
                 val Ident(from) = fromId
-                selection(if (name.isTypeName) from.toTypeName else from)
+                unambiguousSelection(if (name.isTypeName) from.toTypeName else from)
               case Ident(Name) =>
-                selection(name)
+                unambiguousSelection(name)
               case _ =>
                 recur(rest)
             }
@@ -225,18 +229,10 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
       /** The type representing a wildcard import with enclosing name when imported
        *  from given import info
        */
-      def wildImportRef(imp: ImportInfo)(implicit ctx: Context): Type = {
-        if (imp.isWildcardImport) {
-          val pre = imp.site
-          if (!unimported.contains(pre.termSymbol) &&
-              !imp.excluded.contains(name.toTermName) &&
-              name != nme.CONSTRUCTOR) {
-            val denot = pre.member(name).accessibleFrom(pre)(refctx)
-            if (reallyExists(denot)) return pre.select(name, denot)
-          }
-        }
-        NoType
-      }
+      def wildImportRef(imp: ImportInfo)(implicit ctx: Context): Type =
+        if (imp.isWildcardImport && !imp.excluded.contains(name.toTermName) && name != nme.CONSTRUCTOR)
+          selection(imp, name)
+        else NoType
 
       /** Is (some alternative of) the given predenotation `denot`
        *  defined in current compilation unit?

tests/pos/i2212.scala

@@ -0,0 +1,19 @@
+package object squants {
+  type Time = squants.time.Time
+}
+package squants.time {
+  class Time
+  object Time { def x = 2 }
+}
+package squants.velocity {
+  import squants.time._  // <-- imports `Time` value
+  import squants.Time // <-- imports  type alias
+  object Velocity { Time.x }
+}
+
+import scala.math.BigDecimal.RoundingMode
+import scala.math.BigDecimal.RoundingMode.RoundingMode
+
+object Money {
+  def foo(round: RoundingMode = RoundingMode.HALF_EVEN): Int = ???
+}

tests/run/t5857.scala

@@ -36,10 +36,9 @@ object Test {
       b
     }
 
-    // whatever it is, it should be less than, say, 250ms
+    // whatever it is, it should be less than, say, 1000ms
     // if `max` involves traversal, it takes over 5 seconds on a 3.2GHz i7 CPU
     //println(exectime)
-    assert(exectime < 250, exectime)
+    assert(exectime < 1000, exectime)
   }
-
 }