Skip to content

Travis-CI config doesn't work from forks #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Jan 28, 2020 · 4 comments · Fixed by scala/scala#9268
Closed

Travis-CI config doesn't work from forks #663

SethTisue opened this issue Jan 28, 2020 · 4 comments · Fixed by scala/scala#9268
Assignees
Milestone

Comments

@SethTisue
Copy link
Member

some contributors might appreciate being able to run PR validation in their forks, for work that isn't ready for the main scala/Scala PR queue

@dwijnand made a brief initial stab at scala/scala#8665 but quickly realized it needed more work

@lrytz
Copy link
Member

lrytz commented Jan 28, 2020

Somewhat related, here is a script that I wrote at some point to do a full bootstrap build locally, using the scripts in the repo: lrytz/scala@25d246d. (For local development and testing, I do it differently though. I basically do sbt setupPublishCoreNonOpt publishLocal and then sbt -Dstarr.version=..... dist/mkQuick.)

Another issue we might run into is time limits. Travis by default gives 50 minutes for public repositories. We got a free upgrade for scala/scala (I think to 90 minutes?) at some point, but that likely doesn't apply to forks. PR builds on travis ususally take 1h to 1h15m.

@dwijnand
Copy link
Member

I also don't think (and highly doubt) forks reused scala/scala's cache, so it's likely longer.

I think it would be fine if forks only ran non-bootstrapped.

@lrytz
Copy link
Member

lrytz commented Jan 28, 2020

The bootstrap doesn't take much time, it's the test suite.

@dwijnand
Copy link
Member

Oh I thought tests were run twice, bootstrapped and non-bootstrapped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants