From 0ab6973530a1e15fe2ae0eae43b85e103b36fb89 Mon Sep 17 00:00:00 2001 From: Nicholas Bishop Date: Thu, 8 Aug 2024 22:40:58 -0400 Subject: [PATCH] Remove dead_code workarounds The changes to dead_code analysis that lead to unwanted warnings have been reverted for now in rustc. --- .github/workflows/rust.yml | 15 --------------- uefi/src/proto/mod.rs | 2 -- 2 files changed, 17 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 3d8b65a06..eabd035fc 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -123,11 +123,6 @@ jobs: build_feature_permutations: name: Build (feature permutations) runs-on: ubuntu-latest - env: - # TODO: temporarily allow warnings to not be errors on nightly due to - # incorrect dead_code lint. - # https://github.com/rust-osdev/uefi-rs/issues/1205 - RUSTFLAGS: "" steps: - name: Checkout sources uses: actions/checkout@v4 @@ -140,11 +135,6 @@ jobs: nightly_channel: name: Nightly (build, test, doc) runs-on: ubuntu-latest - env: - # TODO: temporarily allow warnings to not be errors on nightly due to - # incorrect dead_code lint. - # https://github.com/rust-osdev/uefi-rs/issues/1205 - RUSTFLAGS: "" steps: - name: Checkout sources uses: actions/checkout@v4 @@ -167,11 +157,6 @@ jobs: miri: name: Unit + Doc Tests (Miri) runs-on: ubuntu-latest - env: - # TODO: temporarily allow warnings to not be errors on nightly due to - # incorrect dead_code lint. - # https://github.com/rust-osdev/uefi-rs/issues/1205 - RUSTFLAGS: "" steps: - name: Checkout sources uses: actions/checkout@v4 diff --git a/uefi/src/proto/mod.rs b/uefi/src/proto/mod.rs index 1650fb983..5919b7afc 100644 --- a/uefi/src/proto/mod.rs +++ b/uefi/src/proto/mod.rs @@ -9,8 +9,6 @@ //! //! [`BootServices`]: crate::table::boot::BootServices#accessing-protocols -#![warn(dead_code)] // https://github.com/rust-osdev/uefi-rs/issues/1205 - use crate::Identify; use core::ffi::c_void;