Skip to content

Release uefi-0.23.0 and uefi-services-0.20.0 #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicholasbishop opened this issue Jun 4, 2023 · 3 comments · Fixed by #846
Closed

Release uefi-0.23.0 and uefi-services-0.20.0 #845

nicholasbishop opened this issue Jun 4, 2023 · 3 comments · Fixed by #846
Assignees
@nicholasbishop

Comments

@nicholasbishop
Copy link
Member

This release is to provide the fix for #842.
@nicholasbishop nicholasbishop self-assigned this Jun 4, 2023
@nicholasbishop nicholasbishop mentioned this issue Jun 4, 2023
Merged
2 tasks
@phip1611
Copy link
Member

phip1611 commented Jun 4, 2023

Why not uefi 0.22.1?

@nicholasbishop
Copy link
Member Author

The public function's signature changed (https://github.com/rust-osdev/uefi-rs/pull/843/files#diff-566d37cddda511108f02e563520d31d6b2f2c897ef3bbf61ea8a97358f16ae35L1164), so it's a breaking API change.

@phip1611
Copy link
Member

phip1611 commented Jun 5, 2023 •
edited
Loading

I think it would also have been fine to yank 0.22 and just release it as 0.22.1. IMHO breaking changes are fine if the release is less than a couple of days old..

But technically, what you did is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicholasbishop nicholasbishop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release uefi-0.23.0 and uefi-services-0.20.0 rust-osdev/uefi-rs
2 participants
@nicholasbishop @phip1611