reductions should take self

Author: gnzlbg

coresimd/ppvt/api/arithmetic_reductions.rs

@@ -5,7 +5,7 @@ macro_rules! impl_arithmetic_reductions {
         impl $id {
             /// Lane-wise addition of the vector elements.
             #[inline(always)]
-            pub fn add(&self) -> $elem_ty {
+            pub fn add(self) -> $elem_ty {
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
                     r += self.extract(i);
@@ -14,7 +14,7 @@ macro_rules! impl_arithmetic_reductions {
             }
             /// Lane-wise substraction of the vector elements.
             #[inline(always)]
-            pub fn sub(&self) -> $elem_ty {
+            pub fn sub(self) -> $elem_ty {
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
                     r -= self.extract(i);
@@ -23,7 +23,7 @@ macro_rules! impl_arithmetic_reductions {
             }
             /// Lane-wise multiplication of the vector elements.
             #[inline(always)]
-            pub fn mul(&self) -> $elem_ty {
+            pub fn mul(self) -> $elem_ty {
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
                     r *= self.extract(i);
@@ -32,7 +32,7 @@ macro_rules! impl_arithmetic_reductions {
             }
             /// Lane-wise division of the vector elements.
             #[inline(always)]
-            pub fn div(&self) -> $elem_ty {
+            pub fn div(self) -> $elem_ty {
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
                     r /= self.extract(i);
@@ -41,7 +41,7 @@ macro_rules! impl_arithmetic_reductions {
             }
             /// Lane-wise remainder of the vector elements.
             #[inline(always)]
-            pub fn rem(&self) -> $elem_ty {
+            pub fn rem(self) -> $elem_ty {
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
                     r %= self.extract(i);

coresimd/ppvt/api/bitwise_reductions.rs

@@ -4,23 +4,23 @@ macro_rules! impl_bitwise_reductions {
     ($id:ident, $elem_ty:ident) => {
         impl $id {
             /// Lane-wise bitwise `and` of the vector elements.
-            pub fn and(&self) -> $elem_ty {
+            pub fn and(self) -> $elem_ty {
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
                     r &= self.extract(i);
                 }
                 r
             }
             /// Lane-wise bitwise `or` of the vector elements.
-            pub fn or(&self) -> $elem_ty {
+            pub fn or(self) -> $elem_ty {
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
                     r |= self.extract(i);
                 }
                 r
             }
             /// Lane-wise bitwise `xor` of the vector elements.
-            pub fn xor(&self) -> $elem_ty {
+            pub fn xor(self) -> $elem_ty {
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
                     r ^= self.extract(i);

coresimd/ppvt/api/boolean_reductions.rs

@@ -5,17 +5,17 @@ macro_rules! impl_bool_reductions {
         impl $id {
             /// Are `all` vector lanes `true`?
             #[inline(always)]
-            pub fn all(&self) -> bool {
+            pub fn all(self) -> bool {
                 self.and()
             }
             /// Is `any` vector lanes `true`?
             #[inline(always)]
-            pub fn any(&self) -> bool {
+            pub fn any(self) -> bool {
                 self.or()
             }
             /// Are `all` vector lanes `false`?
             #[inline(always)]
-            pub fn none(&self) -> bool {
+            pub fn none(self) -> bool {
                 !self.or()
             }
         }

coresimd/ppvt/api/minmax_reductions.rs

@@ -6,7 +6,7 @@ macro_rules! impl_minmax_reductions {
             /// Largest vector value.
             #[inline(always)]
             #[allow(unused_imports)]
-            pub fn max(&self) -> $elem_ty {
+            pub fn max(self) -> $elem_ty {
                 use num::Float;
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {
@@ -17,7 +17,7 @@ macro_rules! impl_minmax_reductions {
             /// Smallest vector value.
             #[inline(always)]
             #[allow(unused_imports)]
-            pub fn min(&self) -> $elem_ty {
+            pub fn min(self) -> $elem_ty {
                 use num::Float;
                 let mut r = self.extract(0);
                 for i in 1..$id::lanes() {