disable llvm add reduction for aarch64

Author: gnzlbg

Cargo.toml

@@ -11,10 +11,3 @@ opt-level = 3
 [profile.bench]
 debug = 1
 opt-level = 3
-
-[profile.test]
-opt-level = 0
-lto = false
-debug-assertions = true
-codegen-units = 1
-panic = 'unwind'

coresimd/ppsv/codegen/min.rs

@@ -193,5 +193,4 @@ mod tests {
         let v = f32x4::new(4., 2., -1., 3.);
         assert_eq!(v.reduce_min(), -1.);
     }
-
 }

coresimd/ppsv/codegen/product.rs

@@ -117,7 +117,7 @@ macro_rules! red_mul {
             fn reduce_mul(self) -> Self::Acc {
                 let mut x = self.extract(0);
                 for i in 1..$id::lanes() {
-                    x += self.extract(i);
+                    x *= self.extract(i);
                 }
                 x
             }

coresimd/ppsv/codegen/sum.rs

@@ -104,10 +104,21 @@ macro_rules! red_add {
     ($id:ident, $elem_ty:ident, $llvm_intr:ident) => {
         impl ReduceAdd for $id {
             type Acc = $elem_ty;
+            #[cfg(not(target_arch = "aarch64"))]
             #[inline]
             fn reduce_add(self) -> Self::Acc {
                 unsafe { $llvm_intr(self) }
             }
+            // FIXME: broken in AArch64
+            #[cfg(target_arch = "aarch64")]
+            #[inline]
+            fn reduce_add(self) -> Self::Acc {
+                let mut x = self.extract(0) as Self::Acc;
+                for i in 1..$id::lanes() {
+                    x += self.extract(i) as Self::Acc;
+                }
+                x
+            }
         }
     };
 }
@@ -152,7 +163,6 @@ macro_rules! red_fadd {
     ($id:ident, $elem_ty:ident, $llvm_intr:ident) => {
         impl ReduceAdd for $id {
             type Acc = $elem_ty;
-            #[cfg(not(target_arch = "aarch64"))]
             #[inline]
             fn reduce_add(self) -> Self::Acc {
                 // FIXME:
@@ -163,16 +173,6 @@ macro_rules! red_fadd {
                 }
                 x
             }
-            // FIXME: broken in AArch64
-            #[cfg(target_arch = "aarch64")]
-            #[inline]
-            fn reduce_add(self) -> Self::Acc {
-                let mut x = self.extract(0) as Self::Acc;
-                for i in 1..$id::lanes() {
-                    x += self.extract(i) as Self::Acc;
-                }
-                x
-            }
         }
     };
 }