From 03bb3bde90a52cfc1d64c15263013d97a3d7aad2 Mon Sep 17 00:00:00 2001 From: bishtpawan Date: Tue, 24 Mar 2020 13:03:01 +0530 Subject: [PATCH 1/6] Add long error explanation for E0710 #61137 --- src/librustc_error_codes/error_codes.rs | 2 +- src/librustc_error_codes/error_codes/E0710.md | 25 +++++++++++++++++++ src/test/ui/unknown-lint-tool-name.stderr | 3 +++ 3 files changed, 29 insertions(+), 1 deletion(-) create mode 100644 src/librustc_error_codes/error_codes/E0710.md diff --git a/src/librustc_error_codes/error_codes.rs b/src/librustc_error_codes/error_codes.rs index 33bfaddc39c9d..86da425060efa 100644 --- a/src/librustc_error_codes/error_codes.rs +++ b/src/librustc_error_codes/error_codes.rs @@ -393,6 +393,7 @@ E0701: include_str!("./error_codes/E0701.md"), E0704: include_str!("./error_codes/E0704.md"), E0705: include_str!("./error_codes/E0705.md"), E0706: include_str!("./error_codes/E0706.md"), +E0710: include_str!("./error_codes/E0710.md"), E0712: include_str!("./error_codes/E0712.md"), E0713: include_str!("./error_codes/E0713.md"), E0714: include_str!("./error_codes/E0714.md"), @@ -604,7 +605,6 @@ E0748: include_str!("./error_codes/E0748.md"), E0708, // `async` non-`move` closures with parameters are not currently // supported // E0709, // multiple different lifetimes used in arguments of `async fn` - E0710, // an unknown tool name found in scoped lint E0711, // a feature has been declared with conflicting stability attributes E0717, // rustc_promotable without stability attribute // E0721, // `await` keyword diff --git a/src/librustc_error_codes/error_codes/E0710.md b/src/librustc_error_codes/error_codes/E0710.md new file mode 100644 index 0000000000000..c0b58eb00f315 --- /dev/null +++ b/src/librustc_error_codes/error_codes/E0710.md @@ -0,0 +1,25 @@ +An unknown tool name found in scoped lint + +Erroneous code example: + +```compile_fail,E0710 +#[allow(clipp::filter_map)] // error: an unknown tool name found in scoped lint: `clipp::filter_map` + +fn main() { + /** + *business logic + */ +} +``` + +Please verify you didn't misspell the tool's name or that you didn't +forget to import it in you project: + +``` +#[allow(clippy::filter_map)] // ok! +fn main() { + /** + *business logic + */ +} +``` \ No newline at end of file diff --git a/src/test/ui/unknown-lint-tool-name.stderr b/src/test/ui/unknown-lint-tool-name.stderr index 1940f61a47b68..f98e15f7cf2f6 100644 --- a/src/test/ui/unknown-lint-tool-name.stderr +++ b/src/test/ui/unknown-lint-tool-name.stderr @@ -36,3 +36,6 @@ LL | #[allow(foo::bar)] error: aborting due to 6 previous errors +For more information about this error, try `rustc --explain E0710`. + + From cd9921ed82759d9e49e337f67d691c2d681f4e16 Mon Sep 17 00:00:00 2001 From: bishtpawan Date: Tue, 24 Mar 2020 13:09:18 +0530 Subject: [PATCH 2/6] Refactor changes --- src/librustc_error_codes/error_codes/E0710.md | 1 - src/test/ui/unknown-lint-tool-name.stderr | 2 -- 2 files changed, 3 deletions(-) diff --git a/src/librustc_error_codes/error_codes/E0710.md b/src/librustc_error_codes/error_codes/E0710.md index c0b58eb00f315..d577cfb1e1299 100644 --- a/src/librustc_error_codes/error_codes/E0710.md +++ b/src/librustc_error_codes/error_codes/E0710.md @@ -4,7 +4,6 @@ Erroneous code example: ```compile_fail,E0710 #[allow(clipp::filter_map)] // error: an unknown tool name found in scoped lint: `clipp::filter_map` - fn main() { /** *business logic diff --git a/src/test/ui/unknown-lint-tool-name.stderr b/src/test/ui/unknown-lint-tool-name.stderr index f98e15f7cf2f6..414816d229cdb 100644 --- a/src/test/ui/unknown-lint-tool-name.stderr +++ b/src/test/ui/unknown-lint-tool-name.stderr @@ -37,5 +37,3 @@ LL | #[allow(foo::bar)] error: aborting due to 6 previous errors For more information about this error, try `rustc --explain E0710`. - - From 10226daa4ee7a2bd61a1d0dd86581990c782278f Mon Sep 17 00:00:00 2001 From: bishtpawan Date: Tue, 24 Mar 2020 15:41:31 +0530 Subject: [PATCH 3/6] Update tools_lints --- src/librustc_error_codes/error_codes/E0710.md | 4 ++-- src/test/ui/tool_lints.stderr | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/librustc_error_codes/error_codes/E0710.md b/src/librustc_error_codes/error_codes/E0710.md index d577cfb1e1299..cbb667d832d5c 100644 --- a/src/librustc_error_codes/error_codes/E0710.md +++ b/src/librustc_error_codes/error_codes/E0710.md @@ -3,7 +3,7 @@ An unknown tool name found in scoped lint Erroneous code example: ```compile_fail,E0710 -#[allow(clipp::filter_map)] // error: an unknown tool name found in scoped lint: `clipp::filter_map` +#[allow(clipp::filter_map)] // error!` fn main() { /** *business logic @@ -21,4 +21,4 @@ fn main() { *business logic */ } -``` \ No newline at end of file +``` diff --git a/src/test/ui/tool_lints.stderr b/src/test/ui/tool_lints.stderr index 86f87784eaf86..b19e137001022 100644 --- a/src/test/ui/tool_lints.stderr +++ b/src/test/ui/tool_lints.stderr @@ -18,3 +18,4 @@ LL | #[warn(foo::bar)] error: aborting due to 3 previous errors +For more information about this error, try `rustc --explain E0710`. \ No newline at end of file From 150916047beaae94096d2fdc95b88fbdb837f242 Mon Sep 17 00:00:00 2001 From: bishtpawan Date: Tue, 24 Mar 2020 17:11:04 +0530 Subject: [PATCH 4/6] Add explanation for inner attribute --- src/librustc_error_codes/error_codes/E0710.md | 42 +++++++++++++++---- 1 file changed, 35 insertions(+), 7 deletions(-) diff --git a/src/librustc_error_codes/error_codes/E0710.md b/src/librustc_error_codes/error_codes/E0710.md index cbb667d832d5c..6f2dfcd232390 100644 --- a/src/librustc_error_codes/error_codes/E0710.md +++ b/src/librustc_error_codes/error_codes/E0710.md @@ -1,13 +1,27 @@ An unknown tool name found in scoped lint -Erroneous code example: +Erroneous code examples: ```compile_fail,E0710 #[allow(clipp::filter_map)] // error!` fn main() { - /** - *business logic - */ + // business logic +} +``` + +```compile_fail,E0710 +#[warn(clipp::filter_map)] // error!` +fn main() { + // business logic +} +``` + +```compile_fail,E0710 +fn main() { + #![deny(clipp::filter_map)] //error! + fn filter() { + //logic + } } ``` @@ -17,8 +31,22 @@ forget to import it in you project: ``` #[allow(clippy::filter_map)] // ok! fn main() { - /** - *business logic - */ + // business logic +} +``` + +``` +#[warn(clippy::filter_map)] // ok! +fn main() { + // business logic +} +``` + +``` +fn main() { + #![deny(clippy::filter_map)] // ok! + fn filter() { + //logic + } } ``` From b31707e683ba90548d4830929ae721bc4dbaf13e Mon Sep 17 00:00:00 2001 From: bishtpawan Date: Tue, 24 Mar 2020 19:06:08 +0530 Subject: [PATCH 5/6] Remove unknown lint from deny attribute --- src/librustc_error_codes/error_codes/E0710.md | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/src/librustc_error_codes/error_codes/E0710.md b/src/librustc_error_codes/error_codes/E0710.md index 6f2dfcd232390..d9cefe2a6da72 100644 --- a/src/librustc_error_codes/error_codes/E0710.md +++ b/src/librustc_error_codes/error_codes/E0710.md @@ -16,15 +16,6 @@ fn main() { } ``` -```compile_fail,E0710 -fn main() { - #![deny(clipp::filter_map)] //error! - fn filter() { - //logic - } -} -``` - Please verify you didn't misspell the tool's name or that you didn't forget to import it in you project: @@ -41,12 +32,3 @@ fn main() { // business logic } ``` - -``` -fn main() { - #![deny(clippy::filter_map)] // ok! - fn filter() { - //logic - } -} -``` From 5c65568f0b0b5f97fc02397c974d206bc3ff0f9d Mon Sep 17 00:00:00 2001 From: bishtpawan Date: Wed, 25 Mar 2020 11:32:23 +0530 Subject: [PATCH 6/6] update tool_lints --- src/test/ui/tool_lints.stderr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/ui/tool_lints.stderr b/src/test/ui/tool_lints.stderr index b19e137001022..1bcd7fd735de8 100644 --- a/src/test/ui/tool_lints.stderr +++ b/src/test/ui/tool_lints.stderr @@ -18,4 +18,4 @@ LL | #[warn(foo::bar)] error: aborting due to 3 previous errors -For more information about this error, try `rustc --explain E0710`. \ No newline at end of file +For more information about this error, try `rustc --explain E0710`.