diff --git a/src/doc/trpl/ffi.md b/src/doc/trpl/ffi.md index 9ede835e521c9..c6b4e21b06c3a 100644 --- a/src/doc/trpl/ffi.md +++ b/src/doc/trpl/ffi.md @@ -238,7 +238,7 @@ However it is often desired that the callback is targeted to a special Rust object. This could be the object that represents the wrapper for the respective C object. -This can be achieved by passing an unsafe pointer to the object down to the +This can be achieved by passing an raw pointer to the object down to the C library. The C library can then include the pointer to the Rust object in the notification. This will allow the callback to unsafely access the referenced Rust object. @@ -368,7 +368,7 @@ On OSX, frameworks behave with the same semantics as a dynamic library. # Unsafe blocks -Some operations, like dereferencing unsafe pointers or calling functions that have been marked +Some operations, like dereferencing raw pointers or calling functions that have been marked unsafe are only allowed inside unsafe blocks. Unsafe blocks isolate unsafety and are a promise to the compiler that the unsafety does not leak out of the block. diff --git a/src/doc/trpl/raw-pointers.md b/src/doc/trpl/raw-pointers.md index 0f189adf40abf..8a3b98b72927b 100644 --- a/src/doc/trpl/raw-pointers.md +++ b/src/doc/trpl/raw-pointers.md @@ -52,9 +52,9 @@ println!("raw points at {}", *raw); It gives this error: ```text -error: dereference of unsafe pointer requires unsafe function or block [E0133] - println!("raw points at{}", *raw); - ^~~~ +error: dereference of raw pointer requires unsafe function or block [E0133] + println!("raw points at {}", *raw); + ^~~~ ``` When you dereference a raw pointer, you’re taking responsibility that it’s not diff --git a/src/libcollections/slice.rs b/src/libcollections/slice.rs index 634b3f56e8e4c..e99fc95d200bd 100644 --- a/src/libcollections/slice.rs +++ b/src/libcollections/slice.rs @@ -370,7 +370,7 @@ impl [T] { core_slice::SliceExt::get_unchecked_mut(self, index) } - /// Returns an unsafe pointer to the slice's buffer + /// Returns an raw pointer to the slice's buffer /// /// The caller must ensure that the slice outlives the pointer this /// function returns, or else it will end up pointing to garbage. diff --git a/src/libcollections/str.rs b/src/libcollections/str.rs index a9725214c1953..c23b0445e8705 100644 --- a/src/libcollections/str.rs +++ b/src/libcollections/str.rs @@ -525,7 +525,7 @@ impl str { core_str::StrExt::as_bytes(&self[..]) } - /// Returns an unsafe pointer to the `&str`'s buffer. + /// Returns a raw pointer to the `&str`'s buffer. /// /// The caller must ensure that the string outlives this pointer, and /// that it is not diff --git a/src/libcollections/vec.rs b/src/libcollections/vec.rs index 0cc0108fd0116..e7b700119f907 100644 --- a/src/libcollections/vec.rs +++ b/src/libcollections/vec.rs @@ -1215,7 +1215,7 @@ impl Vec { let ln = self.len(); if ln < 1 { return; } - // Avoid bounds checks by using unsafe pointers. + // Avoid bounds checks by using raw pointers. let p = self.as_mut_ptr(); let mut r: usize = 1; let mut w: usize = 1; diff --git a/src/libcore/intrinsics.rs b/src/libcore/intrinsics.rs index 16094f2e6cc3c..774f86563d79c 100644 --- a/src/libcore/intrinsics.rs +++ b/src/libcore/intrinsics.rs @@ -46,7 +46,7 @@ use marker::Sized; extern "rust-intrinsic" { - // NB: These intrinsics take unsafe pointers because they mutate aliased + // NB: These intrinsics take raw pointers because they mutate aliased // memory, which is not valid for either `&` or `&mut`. pub fn atomic_cxchg(dst: *mut T, old: T, src: T) -> T; diff --git a/src/libcore/marker.rs b/src/libcore/marker.rs index bc0f3045972fe..7c20722b26d47 100644 --- a/src/libcore/marker.rs +++ b/src/libcore/marker.rs @@ -357,7 +357,7 @@ macro_rules! impls{ /// struct is dropped, it may in turn drop one or more instances of /// the type `T`, though that may not be apparent from the other /// structure of the type itself. This is commonly necessary if the -/// structure is using an unsafe pointer like `*mut T` whose referent +/// structure is using a raw pointer like `*mut T` whose referent /// may be dropped when the type is dropped, as a `*mut T` is /// otherwise not treated as owned. /// diff --git a/src/libcore/ptr.rs b/src/libcore/ptr.rs index 47c029f11b38f..9ca9b4fc46c99 100644 --- a/src/libcore/ptr.rs +++ b/src/libcore/ptr.rs @@ -10,16 +10,16 @@ // FIXME: talk about offset, copy_memory, copy_nonoverlapping_memory -//! Operations on unsafe pointers, `*const T`, and `*mut T`. +//! Operations on raw pointers, `*const T`, and `*mut T`. //! -//! Working with unsafe pointers in Rust is uncommon, +//! Working with raw pointers in Rust is uncommon, //! typically limited to a few patterns. //! //! Use the `null` function to create null pointers, and the `is_null` method //! of the `*const T` type to check for null. The `*const T` type also defines //! the `offset` method, for pointer math. //! -//! # Common ways to create unsafe pointers +//! # Common ways to create raw pointers //! //! ## 1. Coerce a reference (`&T`) or mutable reference (`&mut T`). //! @@ -86,7 +86,7 @@ //! //! Usually you wouldn't literally use `malloc` and `free` from Rust, //! but C APIs hand out a lot of pointers generally, so are a common source -//! of unsafe pointers in Rust. +//! of raw pointers in Rust. #![stable(feature = "rust1", since = "1.0.0")] #![doc(primitive = "pointer")] diff --git a/src/librustc/middle/effect.rs b/src/librustc/middle/effect.rs index cfff439f02d19..defdf2ae08865 100644 --- a/src/librustc/middle/effect.rs +++ b/src/librustc/middle/effect.rs @@ -162,7 +162,7 @@ impl<'a, 'tcx, 'v> Visitor<'v> for EffectCheckVisitor<'a, 'tcx> { debug!("effect: unary case, base type is {}", ppaux::ty_to_string(self.tcx, base_type)); if let ty::ty_ptr(_) = base_type.sty { - self.require_unsafe(expr.span, "dereference of unsafe pointer") + self.require_unsafe(expr.span, "dereference of raw pointer") } } ast::ExprAssign(ref base, _) | ast::ExprAssignOp(_, ref base, _) => { diff --git a/src/librustc/middle/mem_categorization.rs b/src/librustc/middle/mem_categorization.rs index 3fff15049930b..82d1b45dadb17 100644 --- a/src/librustc/middle/mem_categorization.rs +++ b/src/librustc/middle/mem_categorization.rs @@ -1546,7 +1546,7 @@ impl<'tcx> cmt_<'tcx> { format!("`Box` content") } UnsafePtr(..) => { - format!("dereference of unsafe pointer") + format!("dereference of raw pointer") } BorrowedPtr(..) => { format!("borrowed content") diff --git a/src/librustc/middle/ty.rs b/src/librustc/middle/ty.rs index 0b014c9e6a20c..ec3e1b3219cd4 100644 --- a/src/librustc/middle/ty.rs +++ b/src/librustc/middle/ty.rs @@ -3644,7 +3644,7 @@ impl TypeContents { *self & TC::ReachesAll) } - /// Includes only those bits that still apply when indirected through an unsafe pointer (`*`) + /// Includes only those bits that still apply when indirected through a raw pointer (`*`) pub fn unsafe_pointer(&self) -> TypeContents { *self & TC::ReachesAll } diff --git a/src/librustc_borrowck/borrowck/gather_loans/gather_moves.rs b/src/librustc_borrowck/borrowck/gather_loans/gather_moves.rs index d0f5aa8cf003b..fef8acf2f7b5c 100644 --- a/src/librustc_borrowck/borrowck/gather_loans/gather_moves.rs +++ b/src/librustc_borrowck/borrowck/gather_loans/gather_moves.rs @@ -137,7 +137,7 @@ fn gather_move<'a, 'tcx>(bccx: &BorrowckCtxt<'a, 'tcx>, move_info.id, move_info.kind); } None => { - // move from rvalue or unsafe pointer, hence ok + // move from rvalue or raw pointer, hence ok } } } diff --git a/src/librustc_borrowck/borrowck/gather_loans/restrictions.rs b/src/librustc_borrowck/borrowck/gather_loans/restrictions.rs index 7078b2b5f1797..248010324f6f5 100644 --- a/src/librustc_borrowck/borrowck/gather_loans/restrictions.rs +++ b/src/librustc_borrowck/borrowck/gather_loans/restrictions.rs @@ -145,7 +145,7 @@ impl<'a, 'tcx> RestrictionsContext<'a, 'tcx> { } } } - // Borrowck is not relevant for unsafe pointers + // Borrowck is not relevant for raw pointers mc::UnsafePtr(..) => Safe } } diff --git a/src/librustc_typeck/check/cast.rs b/src/librustc_typeck/check/cast.rs index 5258a77204d60..b84572292923a 100644 --- a/src/librustc_typeck/check/cast.rs +++ b/src/librustc_typeck/check/cast.rs @@ -341,8 +341,8 @@ impl<'tcx> CastCheck<'tcx> { // Due to the limitations of LLVM global constants, // region pointers end up pointing at copies of // vector elements instead of the original values. - // To allow unsafe pointers to work correctly, we - // need to special-case obtaining an unsafe pointer + // To allow raw pointers to work correctly, we + // need to special-case obtaining a raw pointer // from a region pointer to a vector. // this will report a type mismatch if needed diff --git a/src/libstd/sys/common/thread_local.rs b/src/libstd/sys/common/thread_local.rs index eb4cbfcfbcdda..3b2cb00d8c47d 100644 --- a/src/libstd/sys/common/thread_local.rs +++ b/src/libstd/sys/common/thread_local.rs @@ -102,7 +102,7 @@ pub struct StaticKey { /// type is entirely safe to use. /// /// Implementations will likely, however, contain unsafe code as this type only -/// operates on `*mut u8`, an unsafe pointer. +/// operates on `*mut u8`, a raw pointer. /// /// # Examples /// diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index dcf6667b60644..32066b744134d 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -4215,7 +4215,7 @@ impl<'a> Parser<'a> { }; if self.is_self_ident() { let span = self.span; - self.span_err(span, "cannot pass self by unsafe pointer"); + self.span_err(span, "cannot pass self by raw pointer"); try!(self.bump()); } // error case, making bogus self ident: diff --git a/src/test/compile-fail/borrowck-move-from-unsafe-ptr.rs b/src/test/compile-fail/borrowck-move-from-unsafe-ptr.rs index 8310d4ba1444a..7284fa7a850f0 100644 --- a/src/test/compile-fail/borrowck-move-from-unsafe-ptr.rs +++ b/src/test/compile-fail/borrowck-move-from-unsafe-ptr.rs @@ -10,7 +10,7 @@ fn foo(x: *const Box) -> Box { - let y = *x; //~ ERROR dereference of unsafe pointer requires unsafe function or block + let y = *x; //~ ERROR dereference of raw pointer requires unsafe function or block return y; } diff --git a/src/test/compile-fail/issue-20801.rs b/src/test/compile-fail/issue-20801.rs index fe7807042e55b..d3b97a9c05863 100644 --- a/src/test/compile-fail/issue-20801.rs +++ b/src/test/compile-fail/issue-20801.rs @@ -40,8 +40,8 @@ pub fn main() { //~^ ERROR cannot move out of borrowed content let c = unsafe { *mut_ptr() }; - //~^ ERROR cannot move out of dereference of unsafe pointer + //~^ ERROR cannot move out of dereference of raw pointer let d = unsafe { *const_ptr() }; - //~^ ERROR cannot move out of dereference of unsafe pointer + //~^ ERROR cannot move out of dereference of raw pointer } diff --git a/src/test/compile-fail/regions-bounded-by-trait-requiring-static.rs b/src/test/compile-fail/regions-bounded-by-trait-requiring-static.rs index 9e4c4e677cc69..19c50d57e1b39 100644 --- a/src/test/compile-fail/regions-bounded-by-trait-requiring-static.rs +++ b/src/test/compile-fail/regions-bounded-by-trait-requiring-static.rs @@ -54,7 +54,7 @@ fn box_with_region_not_ok<'a>() { assert_send::>(); //~ ERROR does not fulfill the required lifetime } -// unsafe pointers are ok unless they point at unsendable things +// raw pointers are ok unless they point at unsendable things fn unsafe_ok1<'a>(_: &'a isize) { assert_send::<*const isize>(); diff --git a/src/test/compile-fail/unsafe-fn-assign-deref-ptr.rs b/src/test/compile-fail/unsafe-fn-assign-deref-ptr.rs index 4ea7051775e13..cff10329b8589 100644 --- a/src/test/compile-fail/unsafe-fn-assign-deref-ptr.rs +++ b/src/test/compile-fail/unsafe-fn-assign-deref-ptr.rs @@ -10,7 +10,7 @@ fn f(p: *const u8) { - *p = 0; //~ ERROR dereference of unsafe pointer requires unsafe function or block + *p = 0; //~ ERROR dereference of raw pointer requires unsafe function or block return; } diff --git a/src/test/compile-fail/unsafe-fn-deref-ptr.rs b/src/test/compile-fail/unsafe-fn-deref-ptr.rs index bdf079e24d2a1..bf87df71fd87d 100644 --- a/src/test/compile-fail/unsafe-fn-deref-ptr.rs +++ b/src/test/compile-fail/unsafe-fn-deref-ptr.rs @@ -10,7 +10,7 @@ fn f(p: *const u8) -> u8 { - return *p; //~ ERROR dereference of unsafe pointer requires unsafe function or block + return *p; //~ ERROR dereference of raw pointer requires unsafe function or block } fn main() { diff --git a/src/test/parse-fail/no-unsafe-self.rs b/src/test/parse-fail/no-unsafe-self.rs index 2a0ed9dcc243f..1cc0e62f5b2d5 100644 --- a/src/test/parse-fail/no-unsafe-self.rs +++ b/src/test/parse-fail/no-unsafe-self.rs @@ -11,14 +11,14 @@ // compile-flags: -Z parse-only trait A { - fn foo(*mut self); //~ ERROR cannot pass self by unsafe pointer - fn bar(*self); //~ ERROR cannot pass self by unsafe pointer + fn foo(*mut self); //~ ERROR cannot pass self by raw pointer + fn bar(*self); //~ ERROR cannot pass self by raw pointer } struct X; impl A for X { - fn foo(*mut self) { } //~ ERROR cannot pass self by unsafe pointer - fn bar(*self) { } //~ ERROR cannot pass self by unsafe pointer + fn foo(*mut self) { } //~ ERROR cannot pass self by raw pointer + fn bar(*self) { } //~ ERROR cannot pass self by raw pointer } fn main() { }