Skip to content

'<' followed by a letter makes cargo doc hang on nightly #70871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tiby312 opened this issue Apr 7, 2020 · 9 comments · Fixed by #71682
Closed

'<' followed by a letter makes cargo doc hang on nightly #70871

tiby312 opened this issue Apr 7, 2020 · 9 comments · Fixed by #71682
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@tiby312
Copy link

tiby312 commented Apr 7, 2020

If I run cargo doc on the below code, it never finishes.

///<a
fn main() {
    println!("Hello, world!");
}

I expected to see it finish.

Problem does not exist on stable

@tiby312 tiby312 added the C-bug Category: This is a bug. label Apr 7, 2020
@sfackler sfackler added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 7, 2020
@jonas-schievink jonas-schievink added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Apr 7, 2020
@jonas-schievink
Copy link
Contributor

cc @rust-lang/rustdoc

@tmiasko
Copy link
Contributor

tmiasko commented Apr 7, 2020

Fixed upstream in pulldown-cmark/pulldown-cmark#438, but not released yet.

@GuillaumeGomez
Copy link
Member

Let's hope next version will be released soon then! :)

@ollie27
Copy link
Member

ollie27 commented Apr 18, 2020

Unfortunately this also affects 1.43 beta.

@ollie27 ollie27 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. labels Apr 18, 2020
@Mark-Simulacrum
Copy link
Member

Hm so this will hit stable in less than a week then. Do we consider it high priority enough to try to push through a release ourselves? (e.g. we can temporarily fork or whatever, perhaps only on the beta branch).

I personally lean towards no but wouldn't be opposed to doing so if t-rustdoc wanted to.

@sjackman
Copy link

This issue halted development at our company for a day until we bisected the issue down to the particular line of code (a comment) that was causing cargo test to hang indefinitely. 😢

Thank you for all of your hard work on Rust. It is my most favourite language. I've been waiting for a suitable replacement for C++, and it has arrived! 😁

@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Apr 29, 2020
@Mark-Simulacrum
Copy link
Member

Looks like there's movement on a point release, pulldown-cmark/pulldown-cmark#439.

I would be in favor of backporting this to beta, since it's a really painful bug to hit...

@sjackman
Copy link

@ehuss
Copy link
Contributor

ehuss commented Apr 29, 2020

Yea, PR to update is up at #71682.

@bors bors closed this as completed in 8192cb6 May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants