Clippy attributes have no effect on struct fields

[spease]

Example:

struct MyTest {
    a: &'static [u64],
}

fn main() -> Result<(), Error> {
    let b = MyTest {
        #[allow(clippy::unreadable_literal)]
        a: &[1234567890],
    };

    Ok(())
}

The #[allow] directive must be placed on the variable assignment to have an effect - where it is now does not seem to cover the field value.

Searched a little bit, but wasn't sure if this goes with any existing issues (not sure if this would be #53012 since I don't think clippy attributes are procedural)

[Centril]

cc @oli-obk

[oli-obk]

This is not a clippy issue:

struct MyTest {
    a: &'static [u64],
}

fn main() -> Result<(), ()> {
    let b = MyTest {
        #[allow(const_err)]
        a: &[0 - 1],
    };

    Ok(())
}

[euclio]

Ran into this with #[allow(deprecated)] today.

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=af56b57628284884d1bed6a1abc8aefc

#![deny(warnings)]

struct Foo {
    #[deprecated]
    deprecated: usize,
}

fn main() {
    let foo = Foo {
        #[allow(deprecated)]
        deprecated: 1,
    };
    
    println!("{}", foo.deprecated)
}

error: use of deprecated item 'Foo::deprecated'
  --> src/main.rs:11:9
   |
11 |         deprecated: 1,
   |         ^^^^^^^^^^^^^
   |
note: lint level defined here
  --> src/main.rs:1:9
   |
1  | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(deprecated)]` implied by `#[deny(warnings)]`

error: use of deprecated item 'Foo::deprecated'
  --> src/main.rs:14:20
   |
14 |     println!("{}", foo.deprecated)
   |                    ^^^^^^^^^^^^^^

error: aborting due to 2 previous errors

Notably putting the #[allow] on the assignment statement also has no effect. The workaround is to put the #[allow] on fn main().

[awoimbee]

This issue is still present.
Attributes have no effect on struct fields during assignment.

How things currently work:

#![deny(warnings)]
struct Foo {
    #[deprecated]
    deprecated: usize,
}
fn main() {
    #[allow(deprecated)]
    let foo = Foo {deprecated: 1};
     #[allow(deprecated)]
    let tmp = foo.deprecated;
    println!("{}", tmp);
}

How we would like things to work:

#![deny(warnings)]
struct Foo {
    #[deprecated]
    deprecated: usize,
}
fn main() {
    let foo = Foo {
        #[allow(deprecated)]
        deprecated: 1
     };
     #[allow(deprecated)]
    let tmp = foo.deprecated;
    println!("{}", tmp);
}

[ClementNerma]

Stil a problem today:

struct Test {
    #[allow(non_snake_case)] // <-- this does nothing
    #[allow(dead_code)] // <-- while this works
    aB: u128,
}