Skip to content

Highlighting still assumes a dark background #50906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bergus opened this issue May 19, 2018 · 3 comments
Open

Highlighting still assumes a dark background #50906

bergus opened this issue May 19, 2018 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. D-papercut Diagnostics: An error or lint that needs small tweaks. O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bergus
Copy link

bergus commented May 19, 2018

Like #7737.

rustc_invisible_error
I'm using Git's MINGW64 with a white background, and the error message is not visible at all. Using the verbose flag didn't show any further information but that rustc failed with exit code 101. It wasn't until I tried to copy the terminal output into a bug report that I realised there actually was some text.

   Compiling cortex-m-demo v0.1.0 (file:///C:/Users/…/cortex-m-quickstart)
error: language item required, but not found: `panic_fmt`

error: aborting due to previous error

error: Could not compile `cortex-m-demo`.

To learn more, run the command again with --verbose.
@kennytm kennytm added A-diagnostics Area: Messages for errors, warnings, and lints O-windows-gnu Toolchain: GNU, Operating system: Windows C-bug Category: This is a bug. labels May 20, 2018
@estebank
Copy link
Contributor

We should be able to query the current background color using COLOR and adapt the highlighted color accordingly.

@estebank estebank added D-papercut Diagnostics: An error or lint that needs small tweaks. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2019
@mati865
Copy link
Contributor

mati865 commented Aug 12, 2020

@rustbot modify labels: -O-windows-gnu +O-windows
Affects all terminals running on Windows (no matter the toolchain).

@rustbot rustbot added O-windows Operating system: Windows and removed O-windows-gnu Toolchain: GNU, Operating system: Windows labels Aug 12, 2020
@kno10
Copy link

kno10 commented Dec 24, 2020

This is not just on Windows.
Same problem on Linux if you don't use dark background (research says, black text on white is better: https://ux.stackexchange.com/a/53268 ).
With a white terminal, the current color scheme is really bad:
rustcolors
can you read any of the yellow text? I can't.

Please add support for white background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. D-papercut Diagnostics: An error or lint that needs small tweaks. O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants