Skip to content

rustdoc still displays "pub" for an exported copy of struct-like enum variants #32545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nodakai opened this issue Mar 28, 2016 · 3 comments
Closed
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@nodakai
Copy link
Contributor

nodakai commented Mar 28, 2016

Continued from #32395

Apparently #32423 was not a complete fix.

https://doc.rust-lang.org/nightly/std/ops/enum.RangeInclusive.html

pub enum RangeInclusive<Idx> {
    pub Empty {
        at: Idx,
    },
    pub NonEmpty {
        start: Idx,
        end: Idx,
    },
}
@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 28, 2016
@mitaa
Copy link
Contributor

mitaa commented Mar 29, 2016

Sorry... T_T

I think this should be fixed with d0f74b6 for good. Can you confirm that (once this has hit the docs)?

@tbu-
Copy link
Contributor

tbu- commented Mar 31, 2016

This has been fixed, it now looks like this:

pub enum RangeInclusive<Idx> {
    Empty {
        at: Idx,
    },
    NonEmpty {
        start: Idx,
        end: Idx,
    },
}

@alexcrichton
Copy link
Member

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants