-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove or unstabilize all deprecated items in 1.0.0 #24691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Figuring that removing deprecated things is worth such a late-stage nomination. |
@alexcrichton has been planning a patch to remove all deprecated items before 1.0. |
This was completed in #24636 which is now merged. |
I found a few that feel through the cracks and are still
|
The goal of that PR was to remove all deprecated items that were slated for deletion before 1.0. The |
So it is a decision to keep them in 1.0 and be stuck with them “forever”? (Really until 2.0, but in a way not making a 2.0 for a very long time is a sign of success.) |
It's a fact of life that we're going to grow deprecated functions over time, so we need to be comfortable with it no matter what. "Being stuck" with these functions has very little overhead to us as the remaining ones are all minor renamings basically and the compiler/tests don't depend on them at all (unlike the old |
Alright, fair enough. Thanks for #24636! |
Previously: http://internals.rust-lang.org/t/remove-or-unstabilize-all-deprecated-items-in-1-0-0/1945
Per SemVer, major releases are the only time when we get to remove stuff. If 1.0.0 final contains any
#[deprecated]
item, we’ll be stuck with them until 2.0 (which hopefully will be in a very long time!)Proposal: Make sure that all
#[deprecated]
items in 1.0.0 are also marked#[unstable]
. This will effectively make them unavailable in beta and release builds, meaning we can remove them in some future 1.x release without breaking backward-compatibility. In terms of release process, this means back-porting a patch to beta. Then a new beta pre-release might be good.Alternative: remove deprecated items entirely.
CC @brson
The text was updated successfully, but these errors were encountered: