Skip to content

suggest --no-verify if the git hook fails #113135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jyn514 opened this issue Jun 28, 2023 · 0 comments · Fixed by #113206
Closed

suggest --no-verify if the git hook fails #113135

jyn514 opened this issue Jun 28, 2023 · 0 comments · Fixed by #113206
Assignees
@chenyukang
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Jun 28, 2023

rust/src/etc/pre-push.sh

Lines 16 to 17 in f6d58ea

cd "$ROOT_DIR"
./x test tidy --set build.locked-deps=true

https://discord.com/channels/273534239310479360/957720175619215380/1123682277243768863
@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust labels Jun 28, 2023
@chenyukang chenyukang self-assigned this Jun 29, 2023
@chenyukang chenyukang mentioned this issue Jun 30, 2023
Merged
@bors bors closed this as completed in 58a61ee Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenyukang chenyukang

Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

User may want to skip tidy check sometimes chenyukang/rust
2 participants
@chenyukang @jyn514