Skip to content

extra::time: test failure on non-PST Windows machine #10307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
klutzy opened this issue Nov 6, 2013 · 0 comments
Closed

extra::time: test failure on non-PST Windows machine #10307

klutzy opened this issue Nov 6, 2013 · 0 comments

Comments

@klutzy
Copy link
Contributor

klutzy commented Nov 6, 2013

extra::time test executes os::setenv("TZ", "America/Los_Angeles");, but Windows doesn't recognize it.
The test passes on buildbot since buildbot just uses PST, but fails on my machine (non-PST).
We should add tests for at least two timezones to ensure correctness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klutzy