Skip to content

Commit d621631

Browse files
committed
Revert "mk: Run 'make install' through install.sh"
This reverts commit e93709a.
1 parent c796f89 commit d621631

File tree

3 files changed

+65
-15
lines changed

3 files changed

+65
-15
lines changed

Makefile.in

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -232,20 +232,19 @@ ifneq ($(strip $(findstring prepare,$(MAKECMDGOALS)) \
232232
include $(CFG_SRC_DIR)mk/prepare.mk
233233
endif
234234

235+
# (Unix) Installation from the build directory
236+
ifneq ($(findstring install,$(MAKECMDGOALS)),)
237+
CFG_INFO := $(info cfg: including install rules)
238+
include $(CFG_SRC_DIR)mk/install.mk
239+
endif
240+
235241
# Source and binary distribution artifacts
236242
ifneq ($(strip $(findstring dist,$(MAKECMDGOALS)) \
237-
$(findstring install,$(MAKECMDGOALS)) \
238243
$(findstring clean,$(MAKECMDGOALS))),)
239244
CFG_INFO := $(info cfg: including dist rules)
240245
include $(CFG_SRC_DIR)mk/dist.mk
241246
endif
242247

243-
# (Unix) Installation from the build directory
244-
ifneq ($(findstring install,$(MAKECMDGOALS)),)
245-
CFG_INFO := $(info cfg: including install rules)
246-
include $(CFG_SRC_DIR)mk/install.mk
247-
endif
248-
249248
# Cleaning
250249
ifneq ($(findstring clean,$(MAKECMDGOALS)),)
251250
CFG_INFO := $(info cfg: including clean rules)

mk/dist.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
# * dist-tar-bins - Ad-hoc Unix binary installers
2323
# * dist-docs - Stage docs for upload
2424

25-
PKG_NAME := $(CFG_PACKAGE_NAME)
25+
PKG_NAME = $(CFG_PACKAGE_NAME)
2626

2727
# License suitable for displaying in a popup
2828
LICENSE.txt: $(S)COPYRIGHT $(S)LICENSE-APACHE $(S)LICENSE-MIT

mk/install.mk

Lines changed: 58 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,68 @@
88
# option. This file may not be copied, modified, or distributed
99
# except according to those terms.
1010

11+
# FIXME: Docs are currently not installed from the stageN dirs.
12+
# For consistency it might be desirable for stageN to be an exact
13+
# mirror of the installation directory structure.
1114

12-
install: dist-install-dir-$(CFG_BUILD)
13-
$(Q)sh tmp/dist/$(PKG_NAME)-$(CFG_BUILD)/install.sh --prefix="$(CFG_PREFIX)"
15+
# The stage we install from
16+
ISTAGE = $(PREPARE_STAGE)
1417

15-
uninstall: dist-install-dir-$(CFG_BUILD)
16-
$(Q)sh tmp/dist/$(PKG_NAME)-$(CFG_BUILD)/install.sh --prefix="$(CFG_PREFIX)" --uninstall
18+
install: PREPARE_HOST=$(CFG_BUILD)
19+
install: PREPARE_TARGETS=$(CFG_TARGET)
20+
install: PREPARE_DIR_CMD=$(DEFAULT_PREPARE_DIR_CMD)
21+
install: PREPARE_BIN_CMD=$(DEFAULT_PREPARE_BIN_CMD)
22+
install: PREPARE_LIB_CMD=$(DEFAULT_PREPARE_LIB_CMD)
23+
install: PREPARE_MAN_CMD=$(DEFAULT_PREPARE_MAN_CMD)
24+
install: PREPARE_SOURCE_DIR=$(PREPARE_HOST)/stage$(PREPARE_STAGE)
25+
install: PREPARE_SOURCE_BIN_DIR=$(PREPARE_SOURCE_DIR)/bin
26+
install: PREPARE_SOURCE_LIB_DIR=$(PREPARE_SOURCE_DIR)/$(CFG_LIBDIR_RELATIVE)
27+
install: PREPARE_SOURCE_MAN_DIR=$(S)/man
28+
install: PREPARE_DEST_BIN_DIR=$(DESTDIR)$(CFG_PREFIX)/bin
29+
install: PREPARE_DEST_LIB_DIR=$(DESTDIR)$(CFG_LIBDIR)
30+
install: PREPARE_DEST_MAN_DIR=$(DESTDIR)$(CFG_MANDIR)/man1
31+
install: prepare-everything
1732

1833

19-
######################################################################
20-
# Android remote installation
21-
######################################################################
34+
# Uninstall code
35+
36+
PREFIX_ROOT = $(CFG_PREFIX)
37+
PREFIX_BIN = $(PREFIX_ROOT)/bin
38+
PREFIX_LIB = $(CFG_LIBDIR)
39+
40+
INSTALL_TOOLS := $(PREPARE_TOOLS)
41+
42+
# Shorthand for build/stageN/bin
43+
HB = $(HBIN$(ISTAGE)_H_$(CFG_BUILD))
44+
HB2 = $(HBIN2_H_$(CFG_BUILD))
45+
# Shorthand for build/stageN/lib
46+
HL = $(HLIB$(ISTAGE)_H_$(CFG_BUILD))
47+
# Shorthand for the prefix bin directory
48+
PHB = $(PREFIX_BIN)
49+
# Shorthand for the prefix bin directory
50+
PHL = $(PREFIX_LIB)
51+
52+
HOST_LIB_FROM_HL_GLOB = \
53+
$(patsubst $(HL)/%,$(PHL)/%,$(wildcard $(HL)/$(1)))
54+
55+
uninstall: $(foreach tool,$(INSTALL_TOOLS),uninstall-tool-$(tool))
56+
$(Q)rm -Rf $(PHL)/$(CFG_RUSTLIBDIR)
57+
58+
define UNINSTALL_TOOL
59+
uninstall-tool-$(1): $$(foreach dep,$$(TOOL_DEPS_$(1)),uninstall-lib-$$(dep))
60+
$$(Q)rm -f $$(PHB)/$(1)$$(X_$$(CFG_BUILD))
61+
$$(Q)rm -f $$(CFG_MANDIR)/man1/$(1).1
62+
endef
63+
64+
$(foreach tool,$(INSTALL_TOOLS),$(eval $(call UNINSTALL_TOOL,$(tool))))
65+
66+
define UNINSTALL_LIB
67+
uninstall-lib-$(1): $$(foreach dep,$$(RUST_DEPS_$(1)),uninstall-lib-$$(dep))
68+
$$(Q)rm -f $$(call HOST_LIB_FROM_HL_GLOB,$$(call CFG_LIB_GLOB_$$(CFG_BUILD),$(1)))
69+
endef
70+
71+
$(foreach lib,$(CRATES),$(eval $(call UNINSTALL_LIB,$(lib))))
72+
2273

2374
# Android runtime setup
2475
# FIXME: This probably belongs somewhere else

0 commit comments

Comments
 (0)