Skip to content

Commit ca2966c

Browse files
committed
Change finalize -> drop.
1 parent 4967bd0 commit ca2966c

File tree

127 files changed

+155
-155
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

127 files changed

+155
-155
lines changed

doc/tutorial-ffi.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ impl<T: Owned> Unique<T> {
183183
184184
#[unsafe_destructor]
185185
impl<T: Owned> Drop for Unique<T> {
186-
fn finalize(&self) {
186+
fn drop(&self) {
187187
unsafe {
188188
let x = intrinsics::init(); // dummy value to swap in
189189
// moving the object out is needed to call the destructor

doc/tutorial.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1979,7 +1979,7 @@ types by the compiler, and may not be overridden:
19791979
> iterations of the language, and often still are.
19801980
19811981
Additionally, the `Drop` trait is used to define destructors. This
1982-
trait defines one method called `finalize`, which is automatically
1982+
trait defines one method called `drop`, which is automatically
19831983
called when a value of the type that implements this trait is
19841984
destroyed, either because the value went out of scope or because the
19851985
garbage collector reclaimed it.
@@ -1990,15 +1990,15 @@ struct TimeBomb {
19901990
}
19911991
19921992
impl Drop for TimeBomb {
1993-
fn finalize(&self) {
1993+
fn drop(&self) {
19941994
for self.explosivity.times {
19951995
println("blam!");
19961996
}
19971997
}
19981998
}
19991999
~~~
20002000

2001-
It is illegal to call `finalize` directly. Only code inserted by the compiler
2001+
It is illegal to call `drop` directly. Only code inserted by the compiler
20022002
may call it.
20032003

20042004
## Declaring and implementing traits

src/etc/vim/syntax/rust.vim

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ syn keyword rustOperator as
1515

1616
syn match rustAssert "\<assert\(\w\)*!"
1717
syn match rustFail "\<fail\(\w\)*!"
18-
syn keyword rustKeyword break copy do drop extern
18+
syn keyword rustKeyword break copy do extern
1919
syn keyword rustKeyword for if impl let log
2020
syn keyword rustKeyword copy do extern
2121
syn keyword rustKeyword for impl let log

src/libextra/arc.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ struct PoisonOnFail {
247247
}
248248

249249
impl Drop for PoisonOnFail {
250-
fn finalize(&self) {
250+
fn drop(&self) {
251251
unsafe {
252252
/* assert!(!*self.failed);
253253
-- might be false in case of cond.wait() */

src/libextra/arena.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ pub struct Arena {
7777

7878
#[unsafe_destructor]
7979
impl Drop for Arena {
80-
fn finalize(&self) {
80+
fn drop(&self) {
8181
unsafe {
8282
destroy_chunk(&self.head);
8383
for self.chunks.each |chunk| {

src/libextra/c_vec.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ struct DtorRes {
5757

5858
#[unsafe_destructor]
5959
impl Drop for DtorRes {
60-
fn finalize(&self) {
60+
fn drop(&self) {
6161
match self.dtor {
6262
option::None => (),
6363
option::Some(f) => f()

src/libextra/future.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pub struct Future<A> {
4444
// over ~fn's that have pipes and so forth within!
4545
#[unsafe_destructor]
4646
impl<A> Drop for Future<A> {
47-
fn finalize(&self) {}
47+
fn drop(&self) {}
4848
}
4949

5050
priv enum FutureState<A> {

src/libextra/net_tcp.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ pub struct TcpSocket {
5757

5858
#[unsafe_destructor]
5959
impl Drop for TcpSocket {
60-
fn finalize(&self) {
60+
fn drop(&self) {
6161
tear_down_socket_data(self.socket_data)
6262
}
6363
}

src/libextra/rc.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ impl<T> Rc<T> {
6868

6969
#[unsafe_destructor]
7070
impl<T> Drop for Rc<T> {
71-
fn finalize(&self) {
71+
fn drop(&self) {
7272
unsafe {
7373
if self.ptr.is_not_null() {
7474
(*self.ptr).count -= 1;
@@ -220,7 +220,7 @@ impl<T> RcMut<T> {
220220

221221
#[unsafe_destructor]
222222
impl<T> Drop for RcMut<T> {
223-
fn finalize(&self) {
223+
fn drop(&self) {
224224
unsafe {
225225
if self.ptr.is_not_null() {
226226
(*self.ptr).count -= 1;

src/libextra/sort.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1207,7 +1207,7 @@ mod big_tests {
12071207

12081208
#[unsafe_destructor]
12091209
impl<'self> Drop for LVal<'self> {
1210-
fn finalize(&self) {
1210+
fn drop(&self) {
12111211
let x = unsafe { local_data::local_data_get(self.key) };
12121212
match x {
12131213
Some(@y) => {

src/libextra/sync.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ struct SemReleaseGeneric<'self, Q> { sem: &'self Sem<Q> }
176176
#[doc(hidden)]
177177
#[unsafe_destructor]
178178
impl<'self, Q:Owned> Drop for SemReleaseGeneric<'self, Q> {
179-
fn finalize(&self) {
179+
fn drop(&self) {
180180
self.sem.release();
181181
}
182182
}
@@ -219,7 +219,7 @@ pub struct Condvar<'self> {
219219
}
220220

221221
#[unsafe_destructor]
222-
impl<'self> Drop for Condvar<'self> { fn finalize(&self) {} }
222+
impl<'self> Drop for Condvar<'self> { fn drop(&self) {} }
223223

224224
impl<'self> Condvar<'self> {
225225
/**
@@ -295,7 +295,7 @@ impl<'self> Condvar<'self> {
295295

296296
#[unsafe_destructor]
297297
impl<'self> Drop for CondvarReacquire<'self> {
298-
fn finalize(&self) {
298+
fn drop(&self) {
299299
unsafe {
300300
// Needs to succeed, instead of itself dying.
301301
do task::unkillable {
@@ -689,7 +689,7 @@ struct RWlockReleaseRead<'self> {
689689
#[doc(hidden)]
690690
#[unsafe_destructor]
691691
impl<'self> Drop for RWlockReleaseRead<'self> {
692-
fn finalize(&self) {
692+
fn drop(&self) {
693693
unsafe {
694694
do task::unkillable {
695695
let state = &mut *self.lock.state.get();
@@ -726,7 +726,7 @@ struct RWlockReleaseDowngrade<'self> {
726726
#[doc(hidden)]
727727
#[unsafe_destructor]
728728
impl<'self> Drop for RWlockReleaseDowngrade<'self> {
729-
fn finalize(&self) {
729+
fn drop(&self) {
730730
unsafe {
731731
do task::unkillable {
732732
let writer_or_last_reader;
@@ -769,12 +769,12 @@ fn RWlockReleaseDowngrade<'r>(lock: &'r RWlock)
769769
/// The "write permission" token used for rwlock.write_downgrade().
770770
pub struct RWlockWriteMode<'self> { priv lock: &'self RWlock }
771771
#[unsafe_destructor]
772-
impl<'self> Drop for RWlockWriteMode<'self> { fn finalize(&self) {} }
772+
impl<'self> Drop for RWlockWriteMode<'self> { fn drop(&self) {} }
773773

774774
/// The "read permission" token used for rwlock.write_downgrade().
775775
pub struct RWlockReadMode<'self> { priv lock: &'self RWlock }
776776
#[unsafe_destructor]
777-
impl<'self> Drop for RWlockReadMode<'self> { fn finalize(&self) {} }
777+
impl<'self> Drop for RWlockReadMode<'self> { fn drop(&self) {} }
778778

779779
impl<'self> RWlockWriteMode<'self> {
780780
/// Access the pre-downgrade rwlock in write mode.
@@ -1104,7 +1104,7 @@ mod tests {
11041104
}
11051105

11061106
impl Drop for SendOnFailure {
1107-
fn finalize(&self) {
1107+
fn drop(&self) {
11081108
self.c.send(());
11091109
}
11101110
}

src/libextra/task_pool.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ pub struct TaskPool<T> {
3535

3636
#[unsafe_destructor]
3737
impl<T> Drop for TaskPool<T> {
38-
fn finalize(&self) {
38+
fn drop(&self) {
3939
for self.channels.iter().advance |channel| {
4040
channel.send(Quit);
4141
}

src/librustc/back/passes.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ pub struct PassManager {
2323
}
2424

2525
impl Drop for PassManager {
26-
fn finalize(&self) {
26+
fn drop(&self) {
2727
unsafe {
2828
llvm::LLVMDisposePassManager(self.llpm);
2929
}

src/librustc/lib/llvm.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2216,7 +2216,7 @@ pub struct target_data_res {
22162216
}
22172217

22182218
impl Drop for target_data_res {
2219-
fn finalize(&self) {
2219+
fn drop(&self) {
22202220
unsafe {
22212221
llvm::LLVMDisposeTargetData(self.TD);
22222222
}
@@ -2253,7 +2253,7 @@ pub struct pass_manager_res {
22532253
}
22542254

22552255
impl Drop for pass_manager_res {
2256-
fn finalize(&self) {
2256+
fn drop(&self) {
22572257
unsafe {
22582258
llvm::LLVMDisposePassManager(self.PM);
22592259
}
@@ -2289,7 +2289,7 @@ pub struct object_file_res {
22892289
}
22902290

22912291
impl Drop for object_file_res {
2292-
fn finalize(&self) {
2292+
fn drop(&self) {
22932293
unsafe {
22942294
llvm::LLVMDisposeObjectFile(self.ObjectFile);
22952295
}
@@ -2326,7 +2326,7 @@ pub struct section_iter_res {
23262326
}
23272327

23282328
impl Drop for section_iter_res {
2329-
fn finalize(&self) {
2329+
fn drop(&self) {
23302330
unsafe {
23312331
llvm::LLVMDisposeSectionIterator(self.SI);
23322332
}

src/librustc/middle/trans/base.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ pub struct _InsnCtxt { _x: () }
110110

111111
#[unsafe_destructor]
112112
impl Drop for _InsnCtxt {
113-
fn finalize(&self) {
113+
fn drop(&self) {
114114
unsafe {
115115
do local_data::local_data_modify(task_local_insn_key) |c| {
116116
do c.map_consume |@ctx| {

src/librustc/middle/trans/common.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ pub struct BuilderRef_res {
110110
}
111111

112112
impl Drop for BuilderRef_res {
113-
fn finalize(&self) {
113+
fn drop(&self) {
114114
unsafe {
115115
llvm::LLVMDisposeBuilder(self.B);
116116
}

src/librustc/middle/trans/context.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ impl CrateContext {
241241

242242
#[unsafe_destructor]
243243
impl Drop for CrateContext {
244-
fn finalize(&self) {
244+
fn drop(&self) {
245245
unsafe {
246246
unset_task_llcx();
247247
}

src/librustc/rustc.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ pub fn monitor(f: ~fn(diagnostic::Emitter)) {
328328
}
329329

330330
impl Drop for finally {
331-
fn finalize(&self) { self.ch.send(done); }
331+
fn drop(&self) { self.ch.send(done); }
332332
}
333333

334334
let _finally = finally { ch: ch };

src/librustc/util/common.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ pub struct _indenter {
4141
}
4242

4343
impl Drop for _indenter {
44-
fn finalize(&self) { debug!("<<"); }
44+
fn drop(&self) { debug!("<<"); }
4545
}
4646

4747
pub fn _indenter(_i: ()) -> _indenter {

src/librustdoc/demo.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ struct Bored {
128128
}
129129

130130
impl Drop for Bored {
131-
fn finalize(&self) { }
131+
fn drop(&self) { }
132132
}
133133

134134
/**

src/libstd/condition.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ struct Guard<'self, T, U> {
9090

9191
#[unsafe_destructor]
9292
impl<'self, T, U> Drop for Guard<'self, T, U> {
93-
fn finalize(&self) {
93+
fn drop(&self) {
9494
unsafe {
9595
debug!("Guard: popping handler from TLS");
9696
let curr = local_data_pop(self.cond.key);

src/libstd/io.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,7 @@ impl FILERes {
989989
}
990990

991991
impl Drop for FILERes {
992-
fn finalize(&self) {
992+
fn drop(&self) {
993993
unsafe {
994994
libc::fclose(self.f);
995995
}
@@ -1234,7 +1234,7 @@ impl FdRes {
12341234
}
12351235

12361236
impl Drop for FdRes {
1237-
fn finalize(&self) {
1237+
fn drop(&self) {
12381238
unsafe {
12391239
libc::close(self.fd);
12401240
}
@@ -1772,7 +1772,7 @@ pub mod fsync {
17721772

17731773
#[unsafe_destructor]
17741774
impl<T:Copy> Drop for Res<T> {
1775-
fn finalize(&self) {
1775+
fn drop(&self) {
17761776
match self.arg.opt_level {
17771777
None => (),
17781778
Some(level) => {

src/libstd/ops.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
#[lang="drop"]
1616
pub trait Drop {
17-
fn finalize(&self); // FIXME(#4332): Rename to "drop"? --pcwalton
17+
fn drop(&self);
1818
}
1919

2020
#[lang="add"]

src/libstd/option.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ fn test_unwrap_resource() {
416416

417417
#[unsafe_destructor]
418418
impl ::ops::Drop for R {
419-
fn finalize(&self) { *(self.i) += 1; }
419+
fn drop(&self) { *(self.i) += 1; }
420420
}
421421

422422
fn R(i: @mut int) -> R {

src/libstd/pipes.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ struct BufferResource<T> {
309309

310310
#[unsafe_destructor]
311311
impl<T> Drop for BufferResource<T> {
312-
fn finalize(&self) {
312+
fn drop(&self) {
313313
unsafe {
314314
// FIXME(#4330) Need self by value to get mutability.
315315
let this: &mut BufferResource<T> = transmute_mut(self);
@@ -672,7 +672,7 @@ pub struct SendPacketBuffered<T, Tbuffer> {
672672

673673
#[unsafe_destructor]
674674
impl<T:Owned,Tbuffer:Owned> Drop for SendPacketBuffered<T,Tbuffer> {
675-
fn finalize(&self) {
675+
fn drop(&self) {
676676
unsafe {
677677
let this: &mut SendPacketBuffered<T,Tbuffer> = transmute(self);
678678
if this.p != None {
@@ -730,7 +730,7 @@ pub struct RecvPacketBuffered<T, Tbuffer> {
730730

731731
#[unsafe_destructor]
732732
impl<T:Owned,Tbuffer:Owned> Drop for RecvPacketBuffered<T,Tbuffer> {
733-
fn finalize(&self) {
733+
fn drop(&self) {
734734
unsafe {
735735
let this: &mut RecvPacketBuffered<T,Tbuffer> = transmute(self);
736736
if this.p != None {

src/libstd/rt/comm.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ impl<T> Peekable<T> for PortOne<T> {
222222

223223
#[unsafe_destructor]
224224
impl<T> Drop for ChanOneHack<T> {
225-
fn finalize(&self) {
225+
fn drop(&self) {
226226
if self.suppress_finalize { return }
227227

228228
unsafe {
@@ -249,7 +249,7 @@ impl<T> Drop for ChanOneHack<T> {
249249

250250
#[unsafe_destructor]
251251
impl<T> Drop for PortOneHack<T> {
252-
fn finalize(&self) {
252+
fn drop(&self) {
253253
if self.suppress_finalize { return }
254254

255255
unsafe {

0 commit comments

Comments
 (0)