Skip to content

Commit c8b142a

Browse files
committed
Fix ICE assigning methods to local variables
This just adds some missing match cases in ty and trans Closes #18412
1 parent 1652a1f commit c8b142a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/librustc/middle/trans/expr.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -833,7 +833,7 @@ fn trans_def<'blk, 'tcx>(bcx: Block<'blk, 'tcx>,
833833
834834
let _icx = push_ctxt("trans_def_lvalue");
835835
match def {
836-
def::DefFn(..) | def::DefStaticMethod(..) |
836+
def::DefFn(..) | def::DefStaticMethod(..) | def::DefMethod(..) |
837837
def::DefStruct(_) | def::DefVariant(..) => {
838838
trans_def_fn_unadjusted(bcx, ref_expr, def)
839839
}
@@ -1191,10 +1191,12 @@ fn trans_def_fn_unadjusted<'blk, 'tcx>(bcx: Block<'blk, 'tcx>,
11911191
let llfn = match def {
11921192
def::DefFn(did, _, _) |
11931193
def::DefStruct(did) | def::DefVariant(_, did, _) |
1194-
def::DefStaticMethod(did, def::FromImpl(_), _) => {
1194+
def::DefStaticMethod(did, def::FromImpl(_), _) |
1195+
def::DefMethod(did, _, def::FromImpl(_)) => {
11951196
callee::trans_fn_ref(bcx, did, ExprId(ref_expr.id))
11961197
}
1197-
def::DefStaticMethod(impl_did, def::FromTrait(trait_did), _) => {
1198+
def::DefStaticMethod(impl_did, def::FromTrait(trait_did), _) |
1199+
def::DefMethod(impl_did, _, def::FromTrait(trait_did)) => {
11981200
meth::trans_static_method_callee(bcx, impl_did,
11991201
trait_did, ref_expr.id)
12001202
}

src/librustc/middle/ty.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3631,7 +3631,7 @@ pub fn expr_kind(tcx: &ctxt, expr: &ast::Expr) -> ExprKind {
36313631
def::DefFn(_, _, true) => RvalueDpsExpr,
36323632

36333633
// Fn pointers are just scalar values.
3634-
def::DefFn(..) | def::DefStaticMethod(..) => RvalueDatumExpr,
3634+
def::DefFn(..) | def::DefStaticMethod(..) | def::DefMethod(..) => RvalueDatumExpr,
36353635

36363636
// Note: there is actually a good case to be made that
36373637
// DefArg's, particularly those of immediate type, ought to

0 commit comments

Comments
 (0)