Skip to content

Commit a34b61f

Browse files
committed
Add some FIXMEs for issue #607
1 parent 021b203 commit a34b61f

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/comp/back/link.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,7 @@ fn build_link_meta(&session::session sess, &ast::crate c,
332332
sha.input_str(len_and_str(name));
333333
}
334334
case (ast::meta_list(_, _)) {
335+
// FIXME (#607): Implement this
335336
fail "unimplemented meta_item variant";
336337
}
337338
}

src/comp/front/attr.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,9 @@ fn eq(@ast::meta_item a, @ast::meta_item b) -> bool {
9696
}
9797
}
9898
case (ast::meta_list(?na, ?la)) {
99-
// FIXME (#487): This involves probably sorting the list by name
99+
// FIXME (#607): Needs implementing
100+
// This involves probably sorting the list by name and
101+
// meta_item variant
100102
fail "unimplemented meta_item variant"
101103
}
102104
}
@@ -115,6 +117,7 @@ fn contains(&vec[@ast::meta_item] haystack, @ast::meta_item needle) -> bool {
115117
ret false;
116118
}
117119

120+
// FIXME: This needs to sort by meta_item variant in addition to the item name
118121
fn sort_meta_items(&vec[@ast::meta_item] items) -> vec[@ast::meta_item] {
119122
fn lteq(&@ast::meta_item ma, &@ast::meta_item mb) -> bool {
120123
fn key(&@ast::meta_item m) -> ast::ident {

0 commit comments

Comments
 (0)