Remove cast to usize for BytePos and CharPos

Juici · Juici · commit 9a1f1777d360 · 2020-09-21T19:42:43.000+01:00
The case shouldn't be necessary and implicitly truncating BytePos is not
desirable.
diff --git a/compiler/rustc_span/src/lib.rs b/compiler/rustc_span/src/lib.rs
@@ -1596,7 +1596,7 @@ macro_rules! impl_pos {
 
                 #[inline(always)]
                 fn add(self, rhs: $ident) -> $ident {
-                    $ident((self.to_usize() + rhs.to_usize()) as $inner_ty)
+                    $ident(self.0 + rhs.0)
                 }
             }
 
@@ -1605,7 +1605,7 @@ macro_rules! impl_pos {
 
                 #[inline(always)]
                 fn sub(self, rhs: $ident) -> $ident {
-                    $ident((self.to_usize() - rhs.to_usize()) as $inner_ty)
+                    $ident(self.0 - rhs.0)
                 }
             }
         )*

Original file line number	Diff line number	Diff line change
`@@ -1596,7 +1596,7 @@ macro_rules! impl_pos {`
`1596`	`1596`
`1597`	`1597`	`#[inline(always)]`
`1598`	`1598`	`fn add(self, rhs: $ident) -> $ident {`
`1599`		`- $ident((self.to_usize() + rhs.to_usize()) as $inner_ty)`
	`1599`	`+ $ident(self.0 + rhs.0)`
`1600`	`1600`	`}`
`1601`	`1601`	`}`
`1602`	`1602`
`@@ -1605,7 +1605,7 @@ macro_rules! impl_pos {`
`1605`	`1605`
`1606`	`1606`	`#[inline(always)]`
`1607`	`1607`	`fn sub(self, rhs: $ident) -> $ident {`
`1608`		`- $ident((self.to_usize() - rhs.to_usize()) as $inner_ty)`
	`1608`	`+ $ident(self.0 - rhs.0)`
`1609`	`1609`	`}`
`1610`	`1610`	`}`
`1611`	`1611`	`)*`